ID5 Analytics: redaction process skips 'ext' on ID5 ID (#7141)

* #26 id5analytics redactin process skips 'ext' on ID5 ID

* #26 stop using startsWith because IE11 doesn't like it

Co-authored-by: Marco Cosentino <mcosentino@id5.io>

modules/id5AnalyticsAdapter.js

@@ -243,10 +243,14 @@ function deepTransformingClone(obj, transform, currentPath = []) {
 // takes (obj, prop) and transforms property "prop" in object "obj".
 // The "match" is an array of path parts. Each part is either a string or an array.
 // In case of array, it represents alternatives which all would match.
-// Special path part '*' matches any subproperty
+// Special path part '*' matches any subproperty or array index.
+// Prefixing a part with "!" makes it negative match (doesn't work with multiple alternatives)
 const CLEANUP_RULES = {};
 CLEANUP_RULES[AUCTION_END] = [{
-  match: [['adUnits', 'bidderRequests'], '*', 'bids', '*', ['userId', 'crumbs'], '*'],
+  match: [['adUnits', 'bidderRequests'], '*', 'bids', '*', ['userId', 'crumbs'], '!id5id'],
+  apply: 'redact'
+}, {
+  match: [['adUnits', 'bidderRequests'], '*', 'bids', '*', ['userId', 'crumbs'], 'id5id', 'uid'],
   apply: 'redact'
 }, {
   match: [['adUnits', 'bidderRequests'], '*', 'bids', '*', 'userIdAsEids', '*', 'uids', '*', ['id', 'ext']],
@@ -288,7 +292,10 @@ function transformFnFromCleanupRules(eventType) {
       }
       for (let fragment = 0; fragment < ruleMatcher.length && match; fragment++) {
         const choices = makeSureArray(ruleMatcher[fragment]);
-        match = !choices.every((choice) => choice !== '*' && path[fragment] !== choice);
+        match = !choices.every((choice) => choice !== '*' &&
+          (choice.charAt(0) === '!'
+            ? path[fragment] === choice.substring(1)
+            : path[fragment] !== choice));
       }
       if (match) {
         const transformfn = TRANSFORM_FUNCTIONS[transformation];

test/spec/modules/id5AnalyticsAdapter_spec.js

@@ -322,12 +322,22 @@ describe('ID5 analytics adapter', () => {
       expect(body.event).to.equal('auctionEnd');
       expect(body.payload.adUnits[0].bids[0].userId).to.eql({
         'criteoId': '__ID5_REDACTED__',
-        'id5id': '__ID5_REDACTED__',
+        'id5id': {
+          'uid': '__ID5_REDACTED__',
+          'ext': {
+            'linkType': 1
+          }
+        },
         'tdid': '__ID5_REDACTED__'
       });
       expect(body.payload.bidderRequests[0].bids[0].userId).to.eql({
         'sharedid': '__ID5_REDACTED__',
-        'id5id': '__ID5_REDACTED__',
+        'id5id': {
+          'uid': '__ID5_REDACTED__',
+          'ext': {
+            'linkType': 1
+          }
+        },
         'tdid': '__ID5_REDACTED__'
       });
       body.payload.adUnits[0].bids[0].userIdAsEids.forEach((userId) => {