remove pubCommonId import from emoteevBidAdapter

prebid · Jun 21, 2019 · 36f93c0 · 36f93c0
1 parent 0f8cb9b
commit 36f93c0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/modules/emoteevBidAdapter.js b/modules/emoteevBidAdapter.js
@@ -22,11 +22,11 @@ import {
   contains,
   deepAccess,
   isArray,
-  getParameterByName
+  getParameterByName,
+  getCookie
 } from '../src/utils';
 import {config} from '../src/config';
 import * as url from '../src/url';
-import {getCookie} from './pubCommonId';
 
 export const BIDDER_CODE = 'emoteev';
 

diff --git a/test/spec/modules/emoteevBidAdapter_spec.js b/test/spec/modules/emoteevBidAdapter_spec.js
@@ -50,7 +50,6 @@ import {
 } from 'modules/emoteevBidAdapter';
 import * as url from '../../../src/url';
 import * as utils from '../../../src/utils';
-import * as pubCommonId from '../../../modules/pubCommonId';
 import {config} from '../../../src/config';
 
 const cannedValidBidRequests = [{
@@ -743,7 +742,7 @@ describe('emoteevBidAdapter', function () {
     let getParameterByNameSpy;
     beforeEach(function () {
       triggerPixelSpy = sinon.spy(utils, 'triggerPixel');
-      getCookieSpy = sinon.spy(pubCommonId, 'getCookie');
+      getCookieSpy = sinon.spy(utils, 'getCookie');
       getConfigSpy = sinon.spy(config, 'getConfig');
       getParameterByNameSpy = sinon.spy(utils, 'getParameterByName');
     });
@@ -770,15 +769,15 @@ describe('emoteevBidAdapter', function () {
         };
         spec.isBidRequestValid(validBidRequest);
         sinon.assert.notCalled(utils.triggerPixel);
-        sinon.assert.notCalled(pubCommonId.getCookie);
+        sinon.assert.notCalled(utils.getCookie);
         sinon.assert.notCalled(config.getConfig);
         sinon.assert.notCalled(utils.getParameterByName);
       });
       it('has intended side-effects', function () {
         const invalidBidRequest = {};
         spec.isBidRequestValid(invalidBidRequest);
         sinon.assert.notCalled(utils.triggerPixel);
-        sinon.assert.notCalled(pubCommonId.getCookie);
+        sinon.assert.notCalled(utils.getCookie);
         sinon.assert.notCalled(config.getConfig);
         sinon.assert.notCalled(utils.getParameterByName);
       });
@@ -787,7 +786,7 @@ describe('emoteevBidAdapter', function () {
       it('has intended side-effects', function () {
         spec.buildRequests(cannedValidBidRequests, cannedBidderRequest);
         sinon.assert.notCalled(utils.triggerPixel);
-        sinon.assert.notCalled(pubCommonId.getCookie);
+        sinon.assert.notCalled(utils.getCookie);
         sinon.assert.callCount(config.getConfig, 3);
         sinon.assert.callCount(utils.getParameterByName, 2);
       });
@@ -796,7 +795,7 @@ describe('emoteevBidAdapter', function () {
       it('has intended side-effects', function () {
         spec.interpretResponse(serverResponse);
         sinon.assert.notCalled(utils.triggerPixel);
-        sinon.assert.notCalled(pubCommonId.getCookie);
+        sinon.assert.notCalled(utils.getCookie);
         sinon.assert.notCalled(config.getConfig);
         sinon.assert.notCalled(utils.getParameterByName);
       });
@@ -806,7 +805,7 @@ describe('emoteevBidAdapter', function () {
         const bidObject = serverResponse.body[0];
         spec.onBidWon(bidObject);
         sinon.assert.calledOnce(utils.triggerPixel);
-        sinon.assert.calledOnce(pubCommonId.getCookie);
+        sinon.assert.calledOnce(utils.getCookie);
         sinon.assert.calledOnce(config.getConfig);
         sinon.assert.calledOnce(utils.getParameterByName);
       });
@@ -815,7 +814,7 @@ describe('emoteevBidAdapter', function () {
       it('has intended side-effects', function () {
         spec.onTimeout(cannedValidBidRequests[0]);
         sinon.assert.calledOnce(utils.triggerPixel);
-        sinon.assert.notCalled(pubCommonId.getCookie);
+        sinon.assert.notCalled(utils.getCookie);
         sinon.assert.calledOnce(config.getConfig);
         sinon.assert.calledOnce(utils.getParameterByName);
       });
@@ -824,7 +823,7 @@ describe('emoteevBidAdapter', function () {
       it('has intended side-effects', function () {
         spec.getUserSyncs({});
         sinon.assert.notCalled(utils.triggerPixel);
-        sinon.assert.notCalled(pubCommonId.getCookie);
+        sinon.assert.notCalled(utils.getCookie);
         sinon.assert.calledOnce(config.getConfig);
         sinon.assert.calledOnce(utils.getParameterByName);
       });