filters for highest bids before rendering

prebid · Feb 8, 2022 · ff9e71a · ff9e71a
1 parent 19d0fb1
commit ff9e71a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/modules/videoModule/adServer.js b/modules/videoModule/adServer.js
@@ -43,7 +43,9 @@ export function AdServerCore(parentModule_) {
    */
   function registerAdServer(config) {
     const vendorCode = config.vendorCode;
-    parentModule.registerSubmodule(vendorCode, vendorCode, config);
+    try {
+      parentModule.registerSubmodule(vendorCode, vendorCode, config);
+    } catch(e) {}
   }
 
   /**

diff --git a/modules/videoModule/coreVideo.js b/modules/videoModule/coreVideo.js
@@ -103,7 +103,9 @@ export function VideoCore(parentModule_) {
    * @param {videoProviderConfig} providerConfig
    */
   function registerProvider(providerConfig) {
-    parentModule.registerSubmodule(providerConfig.divId, providerConfig.vendorCode, providerConfig);
+    try {
+      parentModule.registerSubmodule(providerConfig.divId, providerConfig.vendorCode, providerConfig);
+    } catch (e) {}
   }
 
   /**

diff --git a/modules/videoModule/index.js b/modules/videoModule/index.js
@@ -27,12 +27,10 @@ export function PbVideo(videoCore_, getConfig_, pbGlobal_, pbEvents_, videoEvent
   function init() {
     getConfig('video', ({ video }) => {
       video.providers.forEach(provider => {
-        try {
-          videoCore.registerProvider(provider);
-          videoCore.onEvents(videoEvents, (type, payload) => {
-            pbEvents.emit(type, payload);
-          }, provider.divId);
-        } catch (e) {}
+        videoCore.registerProvider(provider);
+        videoCore.onEvents(videoEvents, (type, payload) => {
+          pbEvents.emit(type, payload);
+        }, provider.divId);
 
         const adServerConfig = provider.adServer;
         if (adServerConfig) {
@@ -87,6 +85,11 @@ export function PbVideo(videoCore_, getConfig_, pbGlobal_, pbEvents_, videoEvent
   }
 
   function renderWinningBid(adUnit) {
+    const highestCpmBids = pbGlobal.getHighestCpmBids(adUnit.code);
+    if (!highestCpmBids.length) {
+      return;
+    }
+
     const videoConfig = adUnit.video;
     const divId = videoConfig.divId;
     const adServerConfig = videoConfig.adServer;
@@ -102,8 +105,7 @@ export function PbVideo(videoCore_, getConfig_, pbGlobal_, pbEvents_, videoEvent
       return;
     }
 
-    const highestCpmBids = pbGlobal.getHighestCpmBids(adUnit.code);
-    const highestBid = highestCpmBids && highestCpmBids.shift();
+    const highestBid = highestCpmBids.shift();
     if (!highestBid) {
       return;
     }