Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLEDGE/PAAPI module's adUnit level config requirement needs lots of changes on publisher side #10105

Closed
pm-harshad-mane opened this issue Jun 15, 2023 · 5 comments · Fixed by #10136
Labels

Comments

@pm-harshad-mane
Copy link
Contributor

pm-harshad-mane commented Jun 15, 2023

Type of issue

Fledge Module requires Module level config, bidder level config and slot level config too.
Refer: https://github.com/prebid/Prebid.js/blob/master/modules/fledgeForGpt.md

Module level and bidder level config can be easily applied with less effort.
But publishers will need to make changes for each slot to enable the Fledge/PAAPI on each slot.

Example to enable the Fledge on slot

pbjs.addAdUnits({
    code: "my-adunit-div",
    // other config here
    ortb2Imp: {
        ext: {
            ae: 1
        }
    }
});

The documentation says, Absence indicates this is not FLEDGE eligible.

My suggestion is to set the default value of ae flag to 1 at the slot level internally through the Fledge module, we should not set the flag to 1 if the user has explicitly set it 0.

This will avoid the publisher's efforts for modifying all slot-level configs on the setup.
The overall fledge flow will execute only if the module is included and enabled (module and bidder config) by the publisher.

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 15, 2023

Perhaps we could consolidate further? eg

pbjs.que.push(function() {
  pbjs.setConfig({
    fledgeForGpt: {
      enabled: true,
      bidders: ['a','b'],
      defaultForSlots: 1
    }
  });
});

@pm-harshad-mane
Copy link
Contributor Author

yes @patmmccann, this approach also works.

@patmmccann
Copy link
Collaborator

@pm-harshad-mane committee agrees this is ready for dev; Pubmatic (or anyone) is welcome to pick it up or prebid could pick it up after a bunch on consent related work in the queue. Let us know if you guys begin development

@laurb9
Copy link
Contributor

laurb9 commented Jun 21, 2023

I (openx) can take a stab at implementing this

@laurb9
Copy link
Contributor

laurb9 commented Jun 22, 2023

To confirm, the expected effect of the config statement above is: only bidders "a" and "b" are enabled for FLEDGE, all adUnits/imps set imp.ext.ae=1 for these bidders if not explicitly set individually ?

Should we take the absence of bidders property in fledgeForGpt to mean all bidders ?
What about bidders: [], could be no bidders or all bidders ? It can be overridden per-bidder with setBidderConfig.

laurb9 added a commit to openx/Prebid.js that referenced this issue Jun 22, 2023
laurb9 added a commit to openx/Prebid.js that referenced this issue Jun 22, 2023
patmmccann pushed a commit that referenced this issue Aug 10, 2023
* FLEDGE: option to configure all adUnits for specific bidders

Resolves #10105

* Update doc

* More tests and consistent values for fledgeEnabled
patmmccann pushed a commit that referenced this issue Aug 14, 2023
* FLEDGE: option to configure all adUnits for specific bidders

Resolves #10105

* Update doc

* More tests and consistent values for fledgeEnabled

* Delete ae instead of setting it to undef when fledge is not enabled

* fix lint

---------

Co-authored-by: Laurentiu Badea <laurentiu.badea@openx.com>
laurb9 added a commit to laurb9/prebid.github.io that referenced this issue Aug 15, 2023
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this issue Aug 28, 2023
* FLEDGE: option to configure all adUnits for specific bidders

Resolves prebid#10105

* Update doc

* More tests and consistent values for fledgeEnabled
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this issue Aug 28, 2023
* FLEDGE: option to configure all adUnits for specific bidders

Resolves prebid#10105

* Update doc

* More tests and consistent values for fledgeEnabled

* Delete ae instead of setting it to undef when fledge is not enabled

* fix lint

---------

Co-authored-by: Laurentiu Badea <laurentiu.badea@openx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants