-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLEDGE/PAAPI module's adUnit level config requirement needs lots of changes on publisher side #10105
Comments
Perhaps we could consolidate further? eg
|
yes @patmmccann, this approach also works. |
@pm-harshad-mane committee agrees this is ready for dev; Pubmatic (or anyone) is welcome to pick it up or prebid could pick it up after a bunch on consent related work in the queue. Let us know if you guys begin development |
I (openx) can take a stab at implementing this |
To confirm, the expected effect of the config statement above is: only bidders "a" and "b" are enabled for FLEDGE, all adUnits/imps set imp.ext.ae=1 for these bidders if not explicitly set individually ? Should we take the absence of |
* FLEDGE: option to configure all adUnits for specific bidders Resolves #10105 * Update doc * More tests and consistent values for fledgeEnabled
* FLEDGE: option to configure all adUnits for specific bidders Resolves #10105 * Update doc * More tests and consistent values for fledgeEnabled * Delete ae instead of setting it to undef when fledge is not enabled * fix lint --------- Co-authored-by: Laurentiu Badea <laurentiu.badea@openx.com>
* FLEDGE: option to configure all adUnits for specific bidders Resolves prebid#10105 * Update doc * More tests and consistent values for fledgeEnabled
* FLEDGE: option to configure all adUnits for specific bidders Resolves prebid#10105 * Update doc * More tests and consistent values for fledgeEnabled * Delete ae instead of setting it to undef when fledge is not enabled * fix lint --------- Co-authored-by: Laurentiu Badea <laurentiu.badea@openx.com>
Type of issue
Fledge Module requires Module level config, bidder level config and slot level config too.
Refer: https://github.com/prebid/Prebid.js/blob/master/modules/fledgeForGpt.md
Module level and bidder level config can be easily applied with less effort.
But publishers will need to make changes for each slot to enable the Fledge/PAAPI on each slot.
Example to enable the Fledge on slot
The documentation says,
Absence indicates this is not FLEDGE eligible
.My suggestion is to set the default value of
ae
flag to1
at the slot level internally through the Fledge module, we should not set the flag to1
if the user has explicitly set it0
.This will avoid the publisher's efforts for modifying all slot-level configs on the setup.
The overall fledge flow will execute only if the module is included and enabled (module and bidder config) by the publisher.
The text was updated successfully, but these errors were encountered: