Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ga tracker should respect tracker name prefix (or allow you to configure it) #291

Closed
bborn opened this issue Mar 31, 2016 · 3 comments
Closed
Labels

Comments

@bborn
Copy link
Contributor

bborn commented Mar 31, 2016

When using multiple GA trackers, you can give each one a name, in which case when you send an event, you need to prefix it with the tracker name:

ga('mytracker.send', 'event', 'Prebid.js Load Time Distribution', dis, bidder, 1, _disibleInteraction);

instead of:

ga('.send', 'event', 'Prebid.js Load Time Distribution', dis, bidder, 1, _disibleInteraction);
(only works for unnamed trackers)

Since Prebid hardcodes this, it fails when using a tracker name. Instead it should pull the tracker prefix from the ga settings, or else allow the user to configure in enableAnalytics

@bborn
Copy link
Contributor Author

bborn commented Mar 31, 2016

More: this happens also in my case because we use Tag Manager to initialize our GA tracker. GTM gives the tracker a name:

screen shot 2016-03-31 at 11 45 14 am

And then PB analytics events fail because they don't use the name prefix:

screen shot 2016-03-31 at 11 45 36 am

That should be
ga("gtm1459442374366.send", "event", "Prebid.js Bids", "Requests", "yieldbot", 1, {nonInteraction: true})

@mkendall07
Copy link
Member

@bborn
Yes we are aware of this but it's not a high priority on our backlog right now. We'll leave this open as a tracker.

protonate pushed a commit that referenced this issue Apr 8, 2016
Support for named GA trackers #291

* bborn-master:
  Make GA integration work with named trackers
@protonate
Copy link
Collaborator

Released with 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants