Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telaria adapter - GenerateUrl: Bid sizes is empty #3331

Closed
ReinoutStevens opened this issue Nov 27, 2018 · 3 comments
Closed

Telaria adapter - GenerateUrl: Bid sizes is empty #3331

ReinoutStevens opened this issue Nov 27, 2018 · 3 comments
Labels
adapter support bug

Comments

@ReinoutStevens
Copy link
Contributor

ReinoutStevens commented Nov 27, 2018 •
edited
Loading

Type of issue

When requesting a video ad the method generateUrl expects bid to have a sizes array. In our test setup this appears to be empty for Telaria.

We pass playerSize, so a size should be known:

var videoAdUnit = {
      code: 'video',
      mediaTypes: {
        video: {
          context: 'instream',
          playerSize: [640, 480],
        },
      },

Test page

http://jsfiddle.net/9uchz0mb/1/

Platform details

Prebid 1.33.0
The bug does not occur in version 1.32.0. This PR may have modified the behavior ( #3274 )

You may get cors errors as only our validated domains work. The described error occurs before this though.
@ReinoutStevens ReinoutStevens changed the title GenerateUrl: Bid sizes is missing GenerateUrl: Bid sizes is empty Nov 27, 2018
@stale
Copy link

stale bot commented Dec 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 11, 2018
@bretg bretg changed the title GenerateUrl: Bid sizes is empty Telaria adapter - GenerateUrl: Bid sizes is empty Dec 12, 2018
@stale stale bot removed the stale label Dec 12, 2018
@bretg
Copy link
Collaborator

bretg commented Dec 12, 2018

@telariaEng - please take a look

@telariaEng
Copy link
Contributor

@bretg thanks for bringing this to our attention :) the adapter was relying on the sizes array to get the player size. We will update it to use mediatypes.video.playerSize instead.

telariaEng pushed a commit to telariaEng/Prebid.js that referenced this issue Dec 13, 2018
updated telaria bid adapter to use player size provided by the bid.me…
cebc764 
…diaTypes.video.playerSize instead of bid.sizes.

prebid#3331
@telariaEng telariaEng mentioned this issue Dec 13, 2018
Merged
9 tasks
bretg pushed a commit that referenced this issue Dec 20, 2018
@telariaEng @bretg
Modified the Telaria Bid Adapter to use bid.mediaTypes.video.playerSi…
e476021 
…ze instead of bid.sizes (#3377)

* Added telaria bid adapter

* more documentation

* Added more test cases. And improved some code in the adapter

* Removed the check for optional params, they are handled in the server. Also updated certain param names used in  the test spec.

* added some spaces to fix CircleCI tests

* added some spaces to fix CircleCI tests

* fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail.

* Reverted the changes

* merged with prebid master.

* creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid.

* - removed an un used method
- Removed the package-lock file.

* merging to master

* updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes.

#3331

* - removed the requirement for having player size
- updated the test spec to reflect the above change
- removed changes to the package-lock.json file.

* added a param to the ad call url to let us know that the request is coming via hb.

* to lower casing the bidder code.
olafbuitelaar pushed a commit to olafbuitelaar/Prebid.js that referenced this issue Jan 3, 2019
@telariaEng @olafbuitelaar
Modified the Telaria Bid Adapter to use bid.mediaTypes.video.playerSi…
ef606ad 
…ze instead of bid.sizes (prebid#3377)

* Added telaria bid adapter

* more documentation

* Added more test cases. And improved some code in the adapter

* Removed the check for optional params, they are handled in the server. Also updated certain param names used in  the test spec.

* added some spaces to fix CircleCI tests

* added some spaces to fix CircleCI tests

* fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail.

* Reverted the changes

* merged with prebid master.

* creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid.

* - removed an un used method
- Removed the package-lock file.

* merging to master

* updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes.

prebid#3331

* - removed the requirement for having player size
- updated the test spec to reflect the above change
- removed changes to the package-lock.json file.

* added a param to the ad call url to let us know that the request is coming via hb.

* to lower casing the bidder code.
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this issue Mar 18, 2019
@telariaEng
Modified the Telaria Bid Adapter to use bid.mediaTypes.video.playerSi…
876700b 
…ze instead of bid.sizes (prebid#3377)

* Added telaria bid adapter

* more documentation

* Added more test cases. And improved some code in the adapter

* Removed the check for optional params, they are handled in the server. Also updated certain param names used in  the test spec.

* added some spaces to fix CircleCI tests

* added some spaces to fix CircleCI tests

* fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail.

* Reverted the changes

* merged with prebid master.

* creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid.

* - removed an un used method
- Removed the package-lock file.

* merging to master

* updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes.

prebid#3331

* - removed the requirement for having player size
- updated the test spec to reflect the above change
- removed changes to the package-lock.json file.

* added a param to the ad call url to let us know that the request is coming via hb.

* to lower casing the bidder code.
harpere pushed a commit that referenced this issue Apr 5, 2019
@telariaEng @harpere
Telaria Adapter: GDPR support (#3701)
111b82f 
* Added telaria bid adapter

* more documentation

* Added more test cases. And improved some code in the adapter

* Removed the check for optional params, they are handled in the server. Also updated certain param names used in  the test spec.

* added some spaces to fix CircleCI tests

* added some spaces to fix CircleCI tests

* fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail.

* Reverted the changes

* merged with prebid master.

* creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid.

* - removed an un used method
- Removed the package-lock file.

* merging to master

* updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes.

#3331

* - removed the requirement for having player size
- updated the test spec to reflect the above change
- removed changes to the package-lock.json file.

* added a param to the ad call url to let us know that the request is coming via hb.

* to lower casing the bidder code.

* Merge branch 'master' of https://github.com/prebid/Prebid.js

# Conflicts:
#	modules/telariaBidAdapter.js

Added GDPR support

* Sending the gdpr & gdpr consent string only if they're defined
aleksatr pushed a commit that referenced this issue Dec 4, 2020
@telariaEng @tremorvideo
Not using utils.isEmpty on non objects (#6036)
5552473 
* Added telaria bid adapter

* more documentation

* Added more test cases. And improved some code in the adapter

* Removed the check for optional params, they are handled in the server. Also updated certain param names used in  the test spec.

* added some spaces to fix CircleCI tests

* added some spaces to fix CircleCI tests

* fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail.

* Reverted the changes

* merged with prebid master.

* creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid.

* - removed an un used method
- Removed the package-lock file.

* merging to master

* updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes.

#3331

* - removed the requirement for having player size
- updated the test spec to reflect the above change
- removed changes to the package-lock.json file.

* added a param to the ad call url to let us know that the request is coming via hb.

* to lower casing the bidder code.

* Merge branch 'master' of https://github.com/prebid/Prebid.js

# Conflicts:
#	modules/telariaBidAdapter.js

Added GDPR support

* Sending the gdpr & gdpr consent string only if they're defined

* - Updated the test ad unit to use 'telaria' as the bidder code.
- Added an example URL.

* using the bidder code constant

* - Implemented the 'onTimeout' callback to fire a pixel when there's a timeout.
- Added the ability to serialize an schain object according to the description provided here: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md

* some mods to the schain tag generation

* - added tests for schain param checking.

* - fixed a malformed url for timeouts

* - Removed a trailing ',' while generating a schain param.

* - Using the schain object from validBidRequest if present. Reverting to checking if params has it if not.

* - reverting changes to merge with master

* - Resolving merge issues

* - some formatting changes

* using val !== '' instead of utils.isEmpty(val)

* Checking for undefined in the getEncodedValIfNotEmpty method

Co-authored-by: Vinay Prasad <vprasad@tremorvideo.com>
Co-authored-by: Vinay Prasad <vprasad@telaria.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapter support bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ReinoutStevens @mkendall07 @bretg @telariaEng