Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync call made to PubMatic by default #356

Closed
yoaap opened this issue May 16, 2016 · 12 comments
Closed

Sync call made to PubMatic by default #356

yoaap opened this issue May 16, 2016 · 12 comments
Assignees
Labels

Comments

@yoaap
Copy link

yoaap commented May 16, 2016

Hi Team,

I'm using the latest version of Prebid. The calls being made to PubMatic are sync by default (They need this to be async). I had a word with PubMatic tech team and below is the sync call to Pubmatic being triggered through Prebid:

http://gads.pubmatic.com/AdServer/AdCallAggregator?SAVersion=1000&pageURL=http%3A%2F%2Fwww.wittyfeed.com%2Fstory%2F19570%2F1%2Fronaldinho-the-legend-and-the-reason-we-are-in-love-with-football%3Fi%3D2&inIframe=1&kadpageurl=http%3A%2F%2Fwww.wittyfeed.com%2Fstory%2F19570%2F1%2Fronaldinho-the-legend-and-the-reason-we-are-in-love-with-football%3Fi%3D2&pubId=143834&kltstamp=2016-5-12%2017%3A8%3A27&timezone=5.5&screenResolution=1440x900&ranreq=0.2652110827127292&adslots=%5BWittyFeed_story_sidebar_ATF%40300x250%2CWittyFeed_story_sidebar_BTF%40300x250%2CWittyFeed_story_top_ATF_leaderboard%40728x90%2CWittyFeed_story_middle_leaderboard%40728x90%2CWittyFeed_story_bottom_leaderboard%40728x90%5D&lmk=1463053107478

The call is by default sync without callback in response. To make it async, a variable
var pm_async_callback_fn= 'pm_async_callback’; needs to be set by PreBid.

This will pass a callback function name in call e.g:
http://gads.pubmatic.com/AdServer/AdCallAggregator?SAVersion=1000&pageURL=http%3A%2F%2Fwww.wittyfeed.com%2Fstory%2F19570%2F1%2Fronaldinho-the-legend-and-the-reason-we-are-in-love-with-football%3Fi%3D2&inIframe=1&kadpageurl=http%3A%2F%2Fwww.wittyfeed.com%2Fstory%2F19570%2F1%2Fronaldinho-the-legend-and-the-reason-we-are-in-love-with-football%3Fi%3D2&pubId=143834&pm_cb=pm_async_callback&kltstamp=2016-5-12%2017%3A8%3A27&timezone=5.5&screenResolution=1440x900&ranreq=0.2652110827127292&adslots=%5BWittyFeed_story_sidebar_ATF%40300x250%2CWittyFeed_story_sidebar_BTF%40300x250%2CWittyFeed_story_top_ATF_leaderboard%40728x90%2CWittyFeed_story_middle_leaderboard%40728x90%2CWittyFeed_story_bottom_leaderboard%40728x90%5D&lmk=1463053107478

Let me know if there's any work around for this issue.

Thanks,
Animesh

@mkendall07
Copy link
Member

@yoaap
Thanks for the info. We'll need to update the PubMatic adapter to support this async version. Shouldn't be a big code change. Feel free to submit a PR if you already have an implementation available.

@yoaap
Copy link
Author

yoaap commented May 19, 2016

Hi Matt,

We don't have implementation available with us. Let me know if there's any way I can help you with this.

Thanks,
Animesh

@protonate protonate self-assigned this Jun 7, 2016
@protonate protonate assigned mkendall07 and unassigned protonate Jun 24, 2016
@mohsink4u
Copy link

mohsink4u commented Jul 8, 2016

Hi Guys,

This is how PubMatic tag looks like.
`<script type="text/javascript">
var pm_optimize_adslots = ['site2_section2@300x250','site3_section3@300x250'];
var pm_pub_id = 7777;
var pm_async_callback_fn= 'pm_async_callback';
</script>

<script type="text/javascript" src="http://ads.pubmatic.com/AdServer/js/gshowad.js"> </script>`

adding this component is going to fix this.
var pm_async_callback_fn= 'pm_async_callback';

Can we have an timeline on this fix. Multiple publishers are facing this issue.

regards,
Mohsink4u

@mkendall07
Copy link
Member

@mohsink4u
Do you have an implementation guide from Pubmatic? To be clear, the current implementation is "async" because it renders the entire pubmatic content into an iframe and listens to the iframe "ready" event. So once the script has been loaded we trigger the callback. While not ideal, it's not "sync".

@mohsink4u
Copy link

You can find PubMatic's implementation guide in ticket : #186
the name of the PDF is Decision Manager Standard 2.4 Technical Integration Guide_1.pdf
and you will need to look for the info in page number 10.

Please let know if this helps.
Mohsink4u

@mohsink4u
Copy link

@mkendall07 , any update on this. Do you need anything else from us.

@dverbru
Copy link

dverbru commented Jul 19, 2016

Hi,
This issue is currently preventing us (as a big publisher) to adopt Prebid.js to integrate with PubMatic. Are there any plans on starting with this soon?

@mkendall07
Copy link
Member

@dverbru , @mohsink4u
PR is up for this change: #453

@mkendall07
Copy link
Member

This is resolved.

@mohsink4u
Copy link

Great to know. Is there any specific build number for this....or how to get the code alongwith with this fix?

Mohsin

@dverbru
Copy link

dverbru commented Jul 21, 2016

Awesome, thank you very much!

@matthewlane
Copy link
Collaborator

@mohsink4u This fix is in Prebid 0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants