-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing http-referrer for img tracking pixels on iOS #977
Comments
Great stuff! I'm all for using HTML 5 when we can. Want to open up a PR? How did you use a mobile device to test with fiddler? Was it emulation or a real device? |
Once I've done some in-house tests I'll open up a PR.
I did the tests on a real device (IOS 10.2.1 on iPad Air). I configured the fiddler on PC as a proxy then configured the ipad to use this proxy. |
Very nice and important. i'm going to test .0.19 build adding srcdoc i can see how this issue is one of the major discrepancy factors. |
It looks like Firefox doesn't support http referrer sending for srcdoc-placed sub-resources. Maybe we should leave the old rendering aproach for Firefox. |
@ckbo3hrk Do you have an updated snippet to use srcdoc only for supported browsers ? |
@mercuryyy |
* fixed leading / omission on ie11 * srcdoc rendering approach to avoid http-referrer omission #977 * missing unit test for url.parse (leading slash in pathname) * move isSrcdocSupported to utils
* fixed leading / omission on ie11 * srcdoc rendering approach to avoid http-referrer omission prebid#977 * missing unit test for url.parse (leading slash in pathname) * move isSrcdocSupported to utils
This is in master. |
* fixed leading / omission on ie11 * srcdoc rendering approach to avoid http-referrer omission prebid#977 * missing unit test for url.parse (leading slash in pathname) * move isSrcdocSupported to utils
Type of issue
[x] Bug ?
Description
During tests on iOS we've noticed that http request for tracking pixel in rendered creatives doesn't contain referrer http-header and that may cause a discrepancy in statistics. The referrer header is absent at least for Safari and Chrome mobile browsers. After some tests I've found that approach with rendering creative in iframe with iframe.srcdoc solves this issue. I beleive that this issue may affect any of ad platforms that relying on http-referrer information from theirs tracking pixels.
Here is POC that fixes this issue:
/src/prebid.js:renderAd
Steps to reproduce
Platform details
IOS 10.2.1 on Ipad Air, Chrome 56.0.2924.79, Safari 10.0, Prebid 0.17.0
The text was updated successfully, but these errors were encountered: