Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identityLinkSubmodule: add additional check on retrieving the envelope #10355

Conversation

mamatic
Copy link
Contributor

@mamatic mamatic commented Aug 14, 2023

Type of change

  • [ X ] Bugfix

Description of change

  • In case when ats library is loaded on a page after prebid, ats will be undefined and ats.retrieveEnvelope function will not get envelope and pass it to callback, but envelope may be present on a page. With this change we will cover the case when envelope is generated but ats is not present on a page, but we still can return envelope.

@mamatic
Copy link
Contributor Author

mamatic commented Aug 14, 2023

@smenzer Can you please do a review?

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer smenzer merged commit 507b5a0 into prebid:master Aug 15, 2023
2 checks passed
jxdeveloper1 added a commit to jxdeveloper1/Prebid.js that referenced this pull request Aug 18, 2023
* master: (107 commits)
  Increment version to 8.11.0-pre
  Prebid 8.10.0 release
  add privacyIcon to not native asset list (prebid#10259)
  gppControl_usstates: activity controls for US state consent (prebid#10283)
  UserID: check for all consent (not just GDPR) to check if an ID needs refreshing (prebid#10286)
  fluct Bid Adapter: add user.data to bid requests (prebid#10318)
  Prebid Server adapter: improve cookie_sync tests, check GPP fields are populated (prebid#10362)
  fix: consolidate banner format array (prebid#10365)
  consentManagementGpp: support GPP 1.1 (prebid#10282)
  Relay Bid Adapter : Initial Release (prebid#10197)
  Yieldmo Bid Adapter : adding 4.x VAST protocol support (prebid#10363)
  Cadent Aperture MX Bid Adapter: support GPP and GPP Section Ids (prebid#10342)
  identityLinkSubmodule: add additional check on retrieving the envelope (prebid#10355)
  fluct Bid Adapter: add gpid to bid requests (prebid#10361)
  Increment version to 8.10.0-pre
  Prebid 8.9.0 release
  fledgeForGpt: consolidate publisher configuration (prebid#10360)
  ConcertBidAdapter: Add `browserLanguage` to request `meta` object (prebid#10356)
  GrowthCode Analytics: Updates/BugFixes (prebid#10339)
  Activity Controls GPP: invalidate covered = 0 in mspa (prebid#10354)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants