Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ozone Bid Adapter : add venatus alias #10602

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

AskRupert-DM
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • [x ] Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • [x ] Other

Description of change

added 'venatus' alias support onto adapter. Minor refactoring of bidAdapter code and spec tests.

newspassid-prebid and others added 2 commits October 12, 2023 19:15
ADAPTER UPDATES FOR ALIAS
Ozone 2.9.1 Adapter Update - new alias support
@ChrisHuie ChrisHuie changed the title Ozone Adapter 2.9.1 - Alias Support Added Ozone Bid Adapter : add venatus alias Oct 12, 2023
@ChrisHuie ChrisHuie self-assigned this Oct 12, 2023
@ChrisHuie
Copy link
Collaborator

@AskRupert-DM can you please add this alias as a new adapter in our docs repo please 🙏

@AskRupert-DM
Copy link
Contributor Author

Thanks - is there a particular entry I need to add to the dev docs file - is it aliasCodes ?

Looking at Xandr as a reference - I don't see any of their aliases referenced per https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/districtmdmx.md (which is an alias of Xandr's adapter) ?

@ChrisHuie
Copy link
Collaborator

Thanks - is there a particular entry I need to add to the dev docs file - is it aliasCodes ?

Looking at Xandr as a reference - I don't see any of their aliases referenced per https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/districtmdmx.md (which is an alias of Xandr's adapter) ?

Usually folks create a new bid adapter that is essentially identical to the adapter that is aliased in the docs.

@AskRupert-DM
Copy link
Contributor Author

Thanks - I've amended the dev docs for now to include the supported alias info - prebid/prebid.github.io#4956

Please let me know if this is ok - keen to get this included in the next Prebid JS release.

@ChrisHuie ChrisHuie merged commit 981459b into prebid:master Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants