Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevant Bid Adapter : support s2s #10610

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

hugolm84
Copy link
Contributor

@hugolm84 hugolm84 commented Oct 13, 2023

Type of change

  • Feature

Description of change

The relevantdigital bid adapter now supports s2s configurations and need to transform params so that server side parameters are valid.

Other information

Related PR's

prebid/prebid-server#3216
prebid/prebid.github.io#4931

@ChrisHuie ChrisHuie changed the title relevantBidAdapter: support s2s Relevant Bid Adapter : support s2s Oct 16, 2023
Copy link
Contributor

@spotxslagle spotxslagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patmmccann
Copy link
Collaborator

@bretg could you take a look; does this make your effort on another issue more difficult?

Also this has no tests

@bretg
Copy link
Collaborator

bretg commented Oct 30, 2023

Talked to Patrick. The concern is that transformBidParams is something we'd hope to deprecate at some point so the client-side adapter is not necessary for server-side bidders. We'll bring up the topic in the next PMC meeting.

In the meantime, it's not a show-stopper for this PR.

@bretg bretg removed their request for review November 1, 2023 14:13
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit tests please

@hugolm84 hugolm84 force-pushed the hlindstrom/relevantBidAdapter branch from b69eed3 to 59444e9 Compare November 3, 2023 08:50
@hugolm84 hugolm84 requested a review from bretg November 3, 2023 08:55
@hugolm84
Copy link
Contributor Author

hugolm84 commented Nov 3, 2023

Add unit tests please

Fixed

@patmmccann patmmccann merged commit d74533b into prebid:master Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants