-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon Bid Adapter: PAAPI/Fledge support #10671
Conversation
@@ -716,6 +720,16 @@ export const spec = { | |||
}, []).sort((adA, adB) => { | |||
return (adB.cpm || 0.0) - (adA.cpm || 0.0); | |||
}); | |||
|
|||
let fledgeAuctionConfigs = responseObj.component_auction_config?.map(config => { | |||
return { config, bidId: config.bidId } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this bidId
returned by AE have to match the bidId
prebid has for the bidRequest?
Where is DV+ getting this bidId
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. They're getting it from the fastlane param we pass in the adapter
return { config, bidId: config.bidId } | ||
}); | ||
|
||
if (fledgeAuctionConfigs) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return {bids, fledgeAuctionConfigs}
should work, core will ignore the second property if it's not an array and still pick up the bids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While that would be better, it breaks some unit tests it's not worth fixing right now. I'll plan to deal with this when we aren't trying to get this out so quickly
@dgirardi would you mind giving this another look? I'm hoping to get this merged today. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ChrisHuie Can this be merged? I'd like to get it in the release this week |
Type of change
Description of change
Rubicon Bid Adapter support for passing PAAPI/Fledge auction configs
Other information