-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JW Player Bid Adapter : initial release #11344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ChrisHuie
changed the title
Module: JW Player Bid Adapter
JW Player Bid Adapter : initial release
Apr 16, 2024
ChrisHuie
approved these changes
Apr 25, 2024
Ticki84
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
May 14, 2024
* jwplayerBidAdapter module created * created initial skeleton of jwplayerBidAdapter * cleaned up initial skeleton for jwplayerBidAdapter * added description to jwplayerBidAdapter.md * created jwplayerBidAdapter unit test suite * implemented isBidRequestValid with unit tests * initial creation of the buildRequests function * incorporated feedback from pr and refactored. * added video object, impExt object, and site content object to jwplayerBidAdapter * added feedback from pr * fixed parameters for methods in jwplayerBidAdapter * added feedback from pr and unit tests * removed superfluous array * fixed nits * added feedback to jw adapter and tests for buildRequests * added feedback * one last feedback for request site * added site object unit test * fixed buildRequestSite object * added unit tests for site object * fixed unit tests for buildRequestSite * skeleton of interpretResponse * initial attempt at interpretResponse * started unit test * finished interpretResponse with unit test * populates schain as well as other params * reads schain from bidrequest * updates unit tests * improves tests * tests tmax * deletes obsolete comments * errors when url is missing * updates tests * implements usersync * supports iframe sync * registers user sync properly * tests user sync * uses boost email * improves ortb reqs * interprets response * updates tests * updates tests * removes playerSize official support * adds md * updates demo * adds content url * adds jwplayer ssp * renames demo --------- Co-authored-by: Jorge Rocha <jrocha@jwplayer.com>
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
* jwplayerBidAdapter module created * created initial skeleton of jwplayerBidAdapter * cleaned up initial skeleton for jwplayerBidAdapter * added description to jwplayerBidAdapter.md * created jwplayerBidAdapter unit test suite * implemented isBidRequestValid with unit tests * initial creation of the buildRequests function * incorporated feedback from pr and refactored. * added video object, impExt object, and site content object to jwplayerBidAdapter * added feedback from pr * fixed parameters for methods in jwplayerBidAdapter * added feedback from pr and unit tests * removed superfluous array * fixed nits * added feedback to jw adapter and tests for buildRequests * added feedback * one last feedback for request site * added site object unit test * fixed buildRequestSite object * added unit tests for site object * fixed unit tests for buildRequestSite * skeleton of interpretResponse * initial attempt at interpretResponse * started unit test * finished interpretResponse with unit test * populates schain as well as other params * reads schain from bidrequest * updates unit tests * improves tests * tests tmax * deletes obsolete comments * errors when url is missing * updates tests * implements usersync * supports iframe sync * registers user sync properly * tests user sync * uses boost email * improves ortb reqs * interprets response * updates tests * updates tests * removes playerSize official support * adds md * updates demo * adds content url * adds jwplayer ssp * renames demo --------- Co-authored-by: Jorge Rocha <jrocha@jwplayer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Introduces the new JW Player Bid Adapter
Other information
Docs PR: prebid/prebid.github.io#5256