Called replaceAuctionMacro in viantOrtbBidAdapter to replace Auction_Price #11394
Conversation
|
@dgirardi can you please review whenever you get a chance? We have a blocker on our side related to the Auction_Price macro issue https://github.com/prebid/Prebid.js/issues/11387. We need to get this PR merged soon. |
|
@patmmccann can you please merge this pull request, we have a blocker on our side related to AUCTION_PRICE macro, and we need your help to merge this PR soon. |
| @@ -51,8 +51,10 @@ export const spec = { | |||
| onBidWon: function (bid) { | |||
| if (bid.burl) { | |||
| utils.triggerPixel(bid.burl); | |||
| utils.replaceAuctionPrice(bid.burl, bid.price); | |||
There was a problem hiding this comment.
@skapoorViant, I aplogize for thinking about this only after merging.
I don't think this does what you want. it should probably be
utils.triggerPixel(utils.replaceAuctionPrice(bid.burl, bid.originalCpm || bid.cpm))
you can do the same for nurl, but by the time this runs it will be a duplicate call.
There was a problem hiding this comment.
no worries, but in the bidresponse we are sending bid.price and not bid.originalCpm or bid.cpm, so would it be good if I just write it as
utils.triggerPixel(utils.replaceAuctionPrice(bid.burl, bid.price||bid.originalCpm || bid.cpm))
…Price (prebid#11394) * Called replaceAuctionMacro in viantOrtbBidAdapter to replace Auction_Price macro * Fixed changes
…Price (prebid#11394) * Called replaceAuctionMacro in viantOrtbBidAdapter to replace Auction_Price macro * Fixed changes
Called replaceAuctionMacro in viantOrtbBidAdapter to replace Auction_Price
Type of change
Description of change
Auction price macro was not getting expanded for bids won with Viant Adapter. Explicitly called replaceAuctionPrice method from utils.js to get the correct value.