-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driftpixel Bid Adapter : initial release #11454
Conversation
modules/driftpixelBidAdapter.js
Outdated
|
||
serverResponse.body.data.forEach(serverBid => { | ||
const bid = { | ||
requestId: bidderRequest.bidId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incorrect to me : the bidderRequest.bidId
field doesn't exist, but there is bidderRequest.bids[x].bidId
(in the bids array), can you double check
} | ||
}; | ||
|
||
const validResponse = spec.interpretResponse(serverResponse, {bidderRequest: defaultRequest}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the format of the bidderRequest is not what will be present with a real bid (this is linked to the first comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add driftpixel Adapter * fix warnings * fix find requestId in interpretResponse * fix format of the bidderRequest --------- Co-authored-by: Chucky-choo <dedafu47@gmail.com>
* add driftpixel Adapter * fix warnings * fix find requestId in interpretResponse * fix format of the bidderRequest --------- Co-authored-by: Chucky-choo <dedafu47@gmail.com>
Type of change
Description of change
Other information
Docs PR: prebid/prebid.github.io#5302