Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beachfront Bid Adapter : add plcmt support #11558

Merged
merged 2 commits into from
May 28, 2024

Conversation

jsalis
Copy link
Contributor

@jsalis jsalis commented May 23, 2024

Type of change

  • Updated bidder adapter
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Update the Beachfront Bid Adapter to add support for video.plcmt

Other information

PR for docs:
prebid/prebid.github.io#5340

@patmmccann
Copy link
Collaborator

are you sure you want to remove support for placement? all that is required is adding support for plcmt

@jsalis
Copy link
Contributor Author

jsalis commented May 24, 2024

Thanks for the clarification. I've updated the PR to keep support for placement.

@jsalis jsalis changed the title Beachfront Bid Adapter: change placement to plcmt Beachfront Bid Adapter: add plcmt support May 24, 2024
@ChrisHuie ChrisHuie self-assigned this May 28, 2024
@ChrisHuie ChrisHuie changed the title Beachfront Bid Adapter: add plcmt support Beachfront Bid Adapter : add plcmt support May 28, 2024
@ChrisHuie ChrisHuie merged commit 6957843 into prebid:master May 28, 2024
4 checks passed
@jsalis jsalis deleted the beachfront-plcmt branch May 30, 2024 22:22
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* change placement to plcmt

* add placement param

---------

Co-authored-by: John Salis <john@beachfront.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants