Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZetaGlobalSppAdapter: remove onTimeout #11576

Merged
merged 1 commit into from
May 28, 2024
Merged

ZetaGlobalSppAdapter: remove onTimeout #11576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions modules/zeta_global_sspBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {registerBidder} from '../src/adapters/bidderFactory.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';
import {config} from '../src/config.js';
import {parseDomain} from '../src/refererDetection.js';
import {ajax} from '../src/ajax.js';

/**
* @typedef {import('../src/adapters/bidderFactory.js').BidRequest} BidRequest
Expand All @@ -15,7 +14,6 @@ import {ajax} from '../src/ajax.js';

const BIDDER_CODE = 'zeta_global_ssp';
const ENDPOINT_URL = 'https://ssp.disqus.com/bid/prebid';
const TIMEOUT_URL = 'https://ssp.disqus.com/timeout/prebid';
const USER_SYNC_URL_IFRAME = 'https://ssp.disqus.com/sync?type=iframe';
const USER_SYNC_URL_IMAGE = 'https://ssp.disqus.com/sync?type=image';
const DEFAULT_CUR = 'USD';
Expand Down Expand Up @@ -268,25 +266,6 @@ export const spec = {
url: USER_SYNC_URL_IMAGE + syncurl
}];
}
},

onTimeout: function(timeoutData) {
if (timeoutData) {
const payload = timeoutData.map(d => ({
bidder: d?.bidder,
shortname: d?.params?.map(p => p?.tags?.shortname).find(p => p),
sid: d?.params?.map(p => p?.sid).find(p => p),
country: d?.ortb2?.device?.geo?.country,
devicetype: d?.ortb2?.device?.devicetype
}));
ajax(TIMEOUT_URL, null, JSON.stringify(payload), {
method: 'POST',
options: {
withCredentials: false,
contentType: 'application/json'
}
});
}
}
}

Expand Down
5 changes: 0 additions & 5 deletions test/spec/modules/zeta_global_sspBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,11 +542,6 @@ describe('Zeta Ssp Bid Adapter', function () {
expect(payload.imp[0].bidfloor).to.eql(params.bidfloor);
});

it('Timeout should exists and be a function', function () {
expect(spec.onTimeout).to.exist.and.to.be.a('function');
expect(spec.onTimeout([{bidder: '1'}])).to.be.undefined;
});

it('Test schain provided', function () {
const request = spec.buildRequests(bannerRequest, bannerRequest[0]);
const payload = JSON.parse(request.data);
Expand Down