Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepIntent Bid Adapter : update video.placement to video.plcmt #11577

Merged
merged 14 commits into from
May 28, 2024

Conversation

parthshah51999
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

fix - update video.placement in favor of video.plcmt

Other information

#10452

@ChrisHuie ChrisHuie changed the title fix - update video.placement in favor of video.plcmt DeepIntent Bid Adapter : update video.placement to video.plcmt May 28, 2024
@ChrisHuie ChrisHuie self-assigned this May 28, 2024
@ChrisHuie ChrisHuie merged commit f6040c4 into prebid:master May 28, 2024
4 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
…d#11577)

* fix user ids not being passed on page reload due to extendId func miss

* remove extendId and add function to read value for eids

* handle inconsistent localstorage values in deepintent id

* remove unused imports

* revert to getValue changes

* revert version in package-lock

* update test suite for deepintent id system

* fix - video.placement was deprecated in favor of video.plcmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants