Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concert Bid Adapter : add dealId Property to Bid Responses #11582

Merged
merged 26 commits into from
May 28, 2024

Conversation

BrettBlox
Copy link
Contributor

Type of change

  • Updated bidder adapter

Description of change

Adds dealid property to be used as hb_deal targeting value.

antoinfive and others added 26 commits September 27, 2022 15:13
[RPO-2922] - Add Prebid Unified Token
[RPO-2971] - Add ad slot positioning to payload
* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log
* Adds check for sharedId

* Updates cookie name

* remove trailing comma
* Adds gpp consent integration to concert bid adapter

* Update tests to check for gpp consent string param

* removes user sync endpoint and tests

* updates comment

* cleans up consentAllowsPpid function

* comment fix

* rename variables for clarity
* Update getUid function to check for pubcid and sharedid

* updates adapter version
ConcertBidAdapter: Add browserLanguage to request meta object
* Add tdid to meta object

* Fix null handling and add tests
* adds dealid property to bid responses

* updates tests

* use first bid for tests

* adds dealid at the correct level
@BrettBlox BrettBlox marked this pull request as ready for review May 28, 2024 15:37
@patmmccann patmmccann self-assigned this May 28, 2024
@ChrisHuie ChrisHuie changed the title Concert Bid Adapter: Add dealId Property to Bid Responses Concert Bid Adapter : add dealId Property to Bid Responses May 28, 2024
@ChrisHuie ChrisHuie merged commit 78f93cd into prebid:master May 28, 2024
2 of 3 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
)

* collect EIDs for bid request

* add ad slot positioning to payload

* RPO-2012: Update local storage name-spacing for c_uid (prebid#8)

* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log

* RPO-2012: Add check for shared id (prebid#9)

* Adds check for sharedId

* Updates cookie name

* remove trailing comma

* [RPO-3152] Enable Support for GPP Consent (prebid#12)

* Adds gpp consent integration to concert bid adapter

* Update tests to check for gpp consent string param

* removes user sync endpoint and tests

* updates comment

* cleans up consentAllowsPpid function

* comment fix

* rename variables for clarity

* fixes conditional logic for consent allows function (prebid#13)

* [RPO-3262] Update getUid function to check for pubcid and sharedid (prebid#14)

* Update getUid function to check for pubcid and sharedid

* updates adapter version

* [RPO-3405] Add browserLanguage to request meta object

* ConcertBidAdapter: Add TDID (prebid#20)

* Add tdid to meta object

* Fix null handling and add tests

* Concert Bid Adapter: Add dealId Property to Bid Responses (prebid#22)

* adds dealid property to bid responses

* updates tests

* use first bid for tests

* adds dealid at the correct level

---------

Co-authored-by: antoin <antoin.campbell@voxmedia.com>
Co-authored-by: Antoin <antoinfive@gmail.com>
Co-authored-by: Sam Ghitelman <sam.ghitelman@voxmedia.com>
Co-authored-by: Sam Ghitelman <SGhitelman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants