Autoplay detection: fix fullscreen issue on iOS #11822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
patmmccann
reviewed
Jun 19, 2024
| const version = navigator.userAgent.match(/iPhone OS (\d+)_(\d+)/) | ||
| if (version !== null && parseInt(version[1]) < 17 && !navigator.userAgent.includes('Safari')) { | ||
| // skip autodetection on iOS 16 WebView | ||
| return |
There was a problem hiding this comment.
This return is not in a function and fails the linter
There was a problem hiding this comment.
Oops my bad, thanks for pointing this out! I'm used to TypeScript + Webpack taking care of this automatically for me, and did not take the time to test it locally on Prebid 😅 I'll fix this tomorrow.
There was a problem hiding this comment.
I have fixed the code and rebased on master, it's all good now @patmmccann 👍
github-matthieu-wipliez
force-pushed
the
autoplay-fix-fullscreen
branch
from
1bdeae6
to
9f041df
Compare
github-matthieu-wipliez
force-pushed
the
autoplay-fix-fullscreen
branch
from
cf8fea2
to
c3c037a
Compare
patmmccann
approved these changes
Jun 21, 2024
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
* Improve autoplay detection to fix fullscreen issue on iOS * Skip autodetection on WebView on iOS < 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR improves the autoplay detection to prevent the video from going fullscreen if autoplay succeeds.
Other information