Adagio Bid Adapter: Add full ORTB2 device data to request payload

[jwrosewell]

Type of change

• Feature
• Updated bidder adapter

Description of change

This PR enhances the Adagio bid request by incorporating device data from the global ORTB2 object. Existing values in the Adagio device object won't be replaced (e.g. language, userAgent, js).

The device object has previously been populated by simplistic parsers, if at all, and was inaccurate as a result. Prebid now benefits from RTD modules such as 51Degrees that enrich all the device object fields including Apple iPhone model category and device ID. The PR enables Adagio’s users to benefit from device object improvements.

Other information

cc: @osazos

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/adagioBidAdapter.js has 9 duplicated lines with modules/insticatorBidAdapter.js
• modules/adagioBidAdapter.js has 18 duplicated lines with modules/mediakeysBidAdapter.js
• modules/adagioBidAdapter.js has 18 duplicated lines with modules/mediakeysBidAdapter.js
• modules/adagioBidAdapter.js has 25 duplicated lines with modules/mediakeysBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[justadreamer]

Hi @osazos any updates on this? Thanks.

[jwrosewell]

@osazos would you like assistance explaining the changes?

[patmmccann]

@osazos can be reach in prebid slack.