IntentIQ Analytics Adapter: browser blacklist #12119
Conversation
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
@patmmccann thanks a lot for the suggestion. Could you please check if everything is okay now? |
|
@jsnellbaker is this PR good to be merged? |
Type of change
Description of change
Add browser blacklist feature to analytics adapter. A list of blocked browsers is provided by the user in the IntentIQ ID module configuration. The list is accessed in analytics module and no reports are sent if current browser is blocked.
Other information