symitriDapRtdProvider : Hash user identity before using it #12129
Conversation
mp4symitri
changed the title
modules/symitriDapRtdProvider.js
Outdated
| * | ||
| */ | ||
|
|
||
| generateHash: function(message) { |
There was a problem hiding this comment.
Why not use browser built in function or hashes already committed to other parts of the project?
There was a problem hiding this comment.
@patmmccann, Browser's built in function uses SubtleCrypto interface that provides crypto.subtle.digest to generate digest. However this digest function is an asynchronous function whereas we want to generate this hash from a synchronous code.
We do use SubtleCrypto for calculating entropy asynchronously but here we needed a synchronous version.
There was a problem hiding this comment.
@patmmccann should this be called from a async call instead?
Are there any other concerns that we need to consider?
|
Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):
|
jpalladino84
force-pushed
the
symitriDapRtdModule-use-hashed-identity
branch
from
3a58ba9
to
e503ca7
Compare
|
Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):
|
jpalladino84
force-pushed
the
symitriDapRtdModule-use-hashed-identity
branch
from
e503ca7
to
702da0d
Compare
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
Removed Publisher Page scrapping Removed onBidWonListener logic Changed documentation Updated related tests
jpalladino84
force-pushed
the
symitriDapRtdModule-use-hashed-identity
branch
from
de99619
to
3674b47
Compare
| enable_download : true | ||
| vendor_specific: true | ||
| sidebarType : 1 | ||
| --- |
There was a problem hiding this comment.
This should be in our docs repo as it is labels for our static site generator -> https://github.com/prebid/prebid.github.io. The markdown file here does not connect at all to our docs site and just lives in the PBjs project as reference
There was a problem hiding this comment.
Thank you for the reminder @ChrisHuie! I will get this opened in a PR against the document repo ASAP!
|
Hi @ncolletti Thanks to @ChrisHuie the build is passing and I update the documentation on prebid.github.io . Let me know if you have any questions or concerns! |
Type of change
Description of change
Added custom sha256 function to synchronously hash user identity as asynchronous hashing function can't be called from synchronous code.
Added code to ensure user identity is hashed before using it.
Updated test cases to test user identifier and hashing algorithm.
Other information