Prebid Core : Remove duplicate event call for actionDebug event #12193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this appears to revert functionality as the event listeners would no longer fire |
|
looks like this change seems ok as it appears the same functionality is occurring here in the logWarn function as stated: https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L235. @dgirardi can you confirm? |
patmmccann
approved these changes
Sep 6, 2024
|
Great point ty |
|
Thanks @patmmccann ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR removes the redundant auction debug logging that was present in the code. The debug log statement was found to be a duplicate of the implementation already handled by the logWarn function. The logWarn function is already invoked within the validateAdUnitPos function, ensuring that the necessary logging occurs without repetition.
By removing this duplicate logging, we streamline the code, reduce unnecessary verbosity in the logs, and improve overall maintainability. This change does not affect the existing functionality, as the necessary logging is still being performed through the logWarn function.
Other information