-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symitri RTD module: OnBidResponse method added #12214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser deals stored in local storage
Documentation Updated.
Fixed Linter Errors Updated Example
OnBidResponse listener added to add pixel for deals matching to the user deals stored in local storage
2 tasks
patmmccann
reviewed
Sep 9, 2024
function onBidResponse(bidResponse, config, userConsent) { | ||
if (bidResponse.dealId && typeof (bidResponse.dealId) != typeof (undefined)) { | ||
let membership = dapUtils.dapGetMembershipFromLocalStorage(); // Get Membership details from Local Storage | ||
let deals = membership.deals; // Get list of Deals the user is mapped to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may want to also check for deals that match a particular pattern
patmmccann
approved these changes
Sep 9, 2024
patmmccann
changed the title
OnBidResponse listener added with support for hashed and composite identifiers
Symetri RTD module: OnBidResponse method added
Sep 9, 2024
patmmccann
changed the title
Symetri RTD module: OnBidResponse method added
Symitri RTD module: OnBidResponse method added
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
OnBidResponse listener added. This listener listens to bid responses and if it finds a response with dealId matching to the one stored in the local storage by the RTD adapter, it will generate a pixel and append it to ad such that it gets triggered upon rendering of the ad.
Also added support for already hashed identifiers or composite identifiers (array of identifiers)
Here is the PR to prebid.github.io repository with documentation update:
prebid/prebid.github.io#5590
Other information