-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharethrough Bid Adapter : update video logic #12217
Merged
ChrisHuie
merged 20 commits into
prebid:master
from
sharethrough:IG-178207483--video-default-updates
Sep 12, 2024
Merged
Sharethrough Bid Adapter : update video logic #12217
ChrisHuie
merged 20 commits into
prebid:master
from
sharethrough:IG-178207483--video-default-updates
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] master from prebid:master
[pull] master from prebid:master
[pull] master from prebid:master
[pull] master from prebid:master
[pull] master from prebid:master
[pull] master from prebid:master
* Updating bid adapter and unit tests to remove some default video logic, which will now be handled within the Sharethrough exchange.
ChrisHuie
approved these changes
Sep 12, 2024
ChrisHuie
changed the title
Sharethrough Bid Adapter: Update video logic
Sharethrough Bid Adapter : update video logic
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updating bid adapter so that some default video values are no longer set within the bid adapter (they will now be applied within Sharethrough's exchange).