Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex Id System: refactoring #12219

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

someden
Copy link
Contributor

@someden someden commented Sep 10, 2024

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Added some additional logs in Yandex Id System.
Improved some jsdoc.

@someden
Copy link
Contributor Author

someden commented Sep 20, 2024

@smenzer could you please take a look?

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks fine, just one question for the prebid team since you modified a common file and that normally requires a second review before merging. Once Chris confirms on that file, the rest of this looks fine and can be merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHuie are you ok with the changes to this file, since it's a common file, but only changes were in the comments.

@patmmccann patmmccann merged commit 3bbf614 into prebid:master Sep 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants