51Degrees RTD submodule: small improvements and fixes #12302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
& small refactor in preparation for the next 51Degrees RTD submodule update
patmmccann
approved these changes
Oct 9, 2024
pdamoc
pushed a commit
to missena-corp/Prebid.js
that referenced
this pull request
Oct 22, 2024
* 51Degrees RTD submodule: calculate PPI based on physical screen size & small refactor in preparation for the next 51Degrees RTD submodule update * 51Degrees RTD submodule: add 51Degrees module to `.submodules.json` * 51Degrees RTD submodule: update documentation --------- Co-authored-by: Bohdan V <25197509+BohdanVV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This pull request introduces several improvements and fixes to the 51Degrees RTD submodule in Prebid.js.
screenpixelsphysicalheightandscreenpixelsphysicalwidth:screenpixelsheightandscreenpixelswidthwhen available.resourceKeyandonPremiseJSUrl, leading to invalid configurations."0", which the module will ignore, allowing for a valid configuration.link preconnectfor optimisation purposes..submodules.json, which was previously omitted.