Greenbids Bidder Adapter

[jeremy-greenbids]

Type of change

New bidder adapter

Module Name: Greenbids Bidder Adapter
Module Type: Bidder Adapter
Maintainer: tech@greenbids.ai

Description

Use greenbids as bidder.

AdUnits configuration example

    var adUnits = [{
      code: 'your-slot_1-div', //use exactly the same code as your slot div id.
      sizes: [[300, 250]],
      bids: [{
          bidder: 'greenbids',
          params: { 
              gbPlacementId: 12345,
          }
      }]
    },{
      code: 'your-slot_2-div', //use exactly the same code as your slot div id.
      sizes: [[600, 800]],
      bids: [{
          bidder: 'greenbids',
          params: { 
              placementId: 12345,
          }
      }]
    }];

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/teadsBidAdapter.js has 28 duplicated lines with libraries/timeToFirstBytesUtils/timeToFirstBytesUtils.js
• modules/greenbidsBidAdapter.js has 22 duplicated lines with modules/teadsBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/teadsBidAdapter.js has 28 duplicated lines with libraries/timeToFirstBytesUtils/timeToFirstBytesUtils.js
• modules/greenbidsBidAdapter.js has 22 duplicated lines with modules/teadsBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[patmmccann]

There's a bunch of utility functions here that can be imported, could you move them all?

Thanks!

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/teadsBidAdapter.js has 28 duplicated lines with libraries/timeToFirstBytesUtils/timeToFirstBytesUtils.js
• modules/greenbidsBidAdapter.js has 22 duplicated lines with modules/teadsBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/teadsBidAdapter.js has 28 duplicated lines with libraries/timeToFirstBytesUtils/timeToFirstBytesUtils.js
• modules/greenbidsBidAdapter.js has 22 duplicated lines with modules/teadsBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[jeremy-greenbids]

@patmmccann the debate for dupplication as been settled on slack. Is it good for the rest please?

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/teadsBidAdapter.js has 28 duplicated lines with libraries/timeToFirstBytesUtils/timeToFirstBytesUtils.js
• modules/greenbidsBidAdapter.js has 20 duplicated lines with modules/teadsBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[jeremy-greenbids]

I think it's good

[jeremy-greenbids]

Can you tell if it is good now please? :)

[jeremy-greenbids]

@patmmccann

[patmmccann]

Welcome to the project!