TNC Id Module : user input url validation and optimizations #12527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/tncIdSystem.js - Optimized User ID Recovery: Replaced the existing user ID recovery function with a faster and more efficient method, improving performance. modules/userId/userId.md - Documentation Correction: Resolved inconsistencies in the documentation, ensuring accurate information for module configuration and usage.
# Conflicts: # modules/tncIdSystem.js
- user input URL validations added
- TNCID recovered from cookie storage if available
- code optimizations for faster TNCID load
________________________________________
test/spec/modules/tncIdSystem_spec.js
- added tests for new functions
________________________________________
modules/tncIdSystem.md
- updated documentation
# Conflicts: # modules/tncIdSystem.js # test/spec/modules/tncIdSystem_spec.js
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
patmmccann
reviewed
Dec 2, 2024
|
Hi patmmccann, Thank you for your feedback so far, let us know if there is anything else we can do to improve our code. |
|
Hi again patmmccann, We removed Sales description from modules/tncIdSystem.md file. Is there something else we can do? Thank you! |
|
Hi patmmccann, This module changes are important for our business. Please let us know if there is anything wrong why this pull is still not approved (committed 2 weeks ago). Thank you! |
ChrisHuie
changed the title
patmmccann
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
modules/tncIdSystem.js
- user input URL validations added
- TNCID recovered from cookie storage if available
- code optimizations for faster TNCID load
test/spec/modules/tncIdSystem_spec.js
- added tests for new functions
modules/tncIdSystem.md
- updated documentation