Prebid Core: Added TTL validation for suppressing expired ads #12532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
@pm-azhar-mulla looks great ty! Let's add docs? |
patmmccann
added
feature
needs docs
needs 2nd review
dgirardi
approved these changes
Dec 3, 2024
2 tasks
ChrisHuie
removed
the
needs 2nd review
ChrisHuie
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We are validating the ttl property before rendering an ad. If the ad has exceeded its ttl value and the
suppressExpiredRenderproperty is enabled, the system will suppress the rendering of the expired ad.We are emitting an event EXPIRED_RENDER similar to STALE_RENDER that publishers can listen to and either render a different ad, call for a new auction, or call the ad server again
Other information
Closes #12521