Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adtelligent bid adapter: add new allias #12559

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

Gunnar97
Copy link
Contributor

@Gunnar97 Gunnar97 commented Dec 9, 2024

Type of change

  • New bidder adapter

Description of change

add new allias stellormedia

Other information

prebid/prebid.github.io#5763

Copy link

github-actions bot commented Dec 9, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/adtelligentBidAdapter.js (+1 error)

@ChrisHuie
Copy link
Collaborator

@Gunnar97 the build issue should be fixed in the most recent version of master if you pull it in

@Gunnar97
Copy link
Contributor Author

@ChrisHuie good day, I have corrected the issue, if possible please make a review

@patmmccann patmmccann self-assigned this Dec 19, 2024
@patmmccann
Copy link
Collaborator

nice work on the duplication

@patmmccann patmmccann merged commit 22ced7d into prebid:master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants