PBS Adapter: fix inconsistency in how bidderconfig is merged, with a special case for EIDs #12571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Dec 12, 2024
ncolletti
approved these changes
Dec 12, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Bidder-specific configuration is treated differently in Prebid.js (
setBidderConfig) and Prebid Server (ext.prebid.bidderconfig). When merging it with global config, JS will attempt to concatenate arrays, while server does not.For consistency, this pre-merges (concatenates) arrays in the PBS adapter, so that merging
ext.prebid.bidderconfigwithout array concatenation would lead to the same result thatsetBidderConfighas client side.The net result is that any bidder-specific array needs to be repeated in its entirety for each bidder. There's a special case for EIDs, since we can take advantage of PBS's
eidpermissionsfeature - this also attempts to use it to avoid repeating them when possible.