Consent Management module bug fix. #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change
ET-1850: Fixing #866
jsnellbaker
approved these changes
May 23, 2018
jsnellbaker
added
LGTM
needs 2nd review
mkendall07
approved these changes
May 23, 2018
jsnellbaker
added a commit
that referenced
this pull request
May 23, 2018
This reverts commit fc95a52.
jsnellbaker
added a commit
that referenced
this pull request
May 23, 2018
This reverts commit fc95a52.
mkendall07
pushed a commit
that referenced
this pull request
May 23, 2018
|
@anand-venkatraman As you may have seen from the additional updates on this PR, we had to partially revert the changes to fix the build on master. The unit test updates were causing some test failures on Safari browsers (see here https://travis-ci.org/prebid/Prebid.js/builds/382804970). If you want to re-include the unit test enhancements, can you please take a look into these errors and create another PR with the updated changes? |
|
@jsnellbaker didnt notice it before, but will check this and create another PR for you. Thanks. |
1 task
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing prebid#866 * Minor fix * Adding mandatory parameters to Bid * GDPR Bug Fix with String response * minor
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Revert "Consent Management module bug fix. (prebid#2588)" This reverts commit fc95a52. * use new file for string includes
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* ET-1691: Pulsepoint Analytics adapter for Prebid. (prebid#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (prebid#2) * ET-1850: Fixing prebid#866 * Minor fix * Adding mandatory parameters to Bid * GDPR Bug Fix with String response * minor
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Revert "Consent Management module bug fix. (prebid#2588)" This reverts commit fc95a52. * use new file for string includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Consent Management module has a bug when the CMP module responds back with
Stringmessage instead ofObject. The code fragment that checks for existence of substringcmpReturn, makes the check usingarray.includes, instead ofstring.includesfrom thecore-jslib.Also the test, was not really testing the code part for iframed pages. Since the existing test created a stub for
window.__cmp, the test was not really running the code branch for "iframed" -callCmpWhileInIframe. Updated the test to verify behavior with bothObjectmessage format andStringmessage format.