update some unit tests to clean-up consentManagement hooks #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapwich
approved these changes
Jun 11, 2018
|
@snapwich Thanks. I checked the addition and it LGTM. |
jsnellbaker
added
the
needs 2nd review
mkendall07
approved these changes
Jun 20, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* update some unit tests to clean-up gdpr module hooks * add cleanup for pubCommonId requestBids hook
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* update some unit tests to clean-up gdpr module hooks * add cleanup for pubCommonId requestBids hook
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* update some unit tests to clean-up gdpr module hooks * add cleanup for pubCommonId requestBids hook
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* update some unit tests to clean-up gdpr module hooks * add cleanup for pubCommonId requestBids hook
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* update some unit tests to clean-up gdpr module hooks * add cleanup for pubCommonId requestBids hook
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* update some unit tests to clean-up gdpr module hooks * add cleanup for pubCommonId requestBids hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This fixes issue #2707
Several unit tests were calling the
config.setConfigto initialize theconsentManagementmodule, but they weren't cleaning up after the test which left a lingering hook on thepbjs.requestBidsfunction that was being used in latter unrelated tests (specifically in thepbjs_api_spec.jsfile).This change adds the necessary clean-up on those tests.