enhance logWarn message #2724
Merged
enhance logWarn message #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-chowla
added
the
needs 2nd review
jaiminpanchal27
approved these changes
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This is to enhance the
utils.logWarnmessage to act like itslogInfoandlogErrorcounterparts.If you pass in an object that's relevant to the problem (ie
utils.logWarn('this object is missing stuff: ', myVar);, that object will be included in the browser's console allowing you to easily see it contents.This is the same functionality that lets you see the
bidRequestsandbidsReceivedobjects in the console in 1.x. See https://github.com/prebid/Prebid.js/blob/master/src/auction.js#L191 for reference usage.