ixBidAdapter.js: allow siteId param to be number

[homeyjd]

In v0.x, the siteID param would be string or number. Somehow, this was restricted to just a string in v1.x.

Type of change

• Bugfix
• Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

This is a backwards-compatibility change only for v0.x => v1.x transition.

The v0.x adapter checked existence of the "siteID" parameter, which has been renamed to "siteId". The IndexExchange migration documentation does not include a reference to restricting the var-type of this parameter, it only mentioned a change in name. To be consistent with the documentation, it must also allow numbers.

Other information

• Not sure who is maintainer of IX adapter. *

[mkendall07]

looks like you have 2 failing test cases. Please resolve. Thanks

[homeyjd]

@mkendall07 Thank you for your patience. Tests corrected.

[ix-prebid-support]

@homeyjd @mkendall07
Having it as string ensures that the number does not get converted into a scientific notation (i.e. 16000 becomes 16e3) in the scenario where config ends up getting minified. Therefore it's much safer to have it as string

[homeyjd]

@ix-prebid-support Thank you for the context, good point.
This PR arose simply because the type-requirement was missing from the migration docs.

a) add type req to docs, reverse this PR, inform advertisers
b) add if (typeof bid.params.siteId === 'number') bid.params.siteId = bid.params.siteId.toFixed(0) in new PR
^^^ Preference?

[ix-prebid-support]

Our preference would be to go with option a in this case.

[homeyjd]

@ix-prebid-support Sounds good. I will change my site's configuration to use strings only in anticipation of your changes.
The commit to reverse is ae287c3 whenever you're ready to submit a new PR:

[ix-prebid-support]

@homeyjd

After some discussions internally, we've decided to keep the support for string as well as number. However, we'll always recommend in the docs to set it as string.