Refactored URL query parameter passthrough for additional values, cha…

[mrcrawfo]

…nged SSP endpoint to v.lkqd.net, and updated associated unit tests

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[harpere]

just verifying that you expect gdpr params to be passed through in the bid params rather than the bidderRequest.gdprConsent object generally sent to buildRequests(): buildRequests: function (bidRequests, bidderRequest) {

[mrcrawfo]

Thank you very much for confirming on this, it's an interesting point. You are correct that we are using custom parameters for our GDPR handling, even though there is likely overlap between your gdprConsent object and our gdprcs (consent string). I was unaware of bidderRequest.gdprConsent so I will have to familiarize myself with the documentation - we will likely add support through this property in a later pull request, but for the moment we are going to proceed with our own implementation. Thank you for bringing this feature to my attention!

[harpere]

just a suggestion to make this more concise - maybe create a function to do this repetitious task. Something like:
function _addParam(param, default) {
if (bidRequest.params.hasOwnProperty(param) && bidRequest.params[param] != null) {
sspData[param] = bidRequest.params[param];
} else if (default != null) {
sspData[param] = default;
}
}

then you just repeat
_addParam(<bidParam>, <optionalDefault>);
or could even put it in a loop (loop through all your params)

[mrcrawfo]

This is a good suggestion - I will look into adding this improvement in a future commit but I would consider it out of scope and don't want it to hold up this current pull request.

[harpere]

Looks good. just have one question and comment.

[mrcrawfo]

Thank you harpere for following up on this pull request, I have read your comments and provided my feedback to answer the remaining question. I think we are clear to proceed, but just let me know if you have anything else you would like to review. Thank you!