33Across: Adapter performance enhancements #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Bid + Crid
Send userSync cookies
Sync based on unique site id
XCH-821 Eliminate preflight
Added alias for contact mailing list
jsnellbaker
approved these changes
Jul 26, 2018
There was a problem hiding this comment.
I tested out these changes and they appear to be working as expected. To confirm, the new values in the .md - are they supposed to return a test ad?
I'm currently receiving the following response when the request goes out:
{"id":"2ee28bdffaca59","cur":"USD","seatbid":[],"ext":{"ttx":{"tactic":"hb","devicetype":2,"iso-3166-alpha-2":"US"}}}
|
@jsnellbaker The response is to be expected. The setup in the .md is does not yield a test bid. |
|
Ok, thanks for confirming. |
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
siteIdrequest param values sincesiteIdis the criteria. Previously, the sync occurred for requests to each ad unit regardless ofsiteIdassociated which resulted in redundant calls hitting user sync limitsBe sure to test the integration with your adserver using the Hello World sample page.
headerbidding@33across.com