Fix safeFrame resize issue #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
approved these changes
Aug 9, 2018
harpere
added
LGTM
needs 2nd review
idettman
removed
the
needs 2nd review
1 task
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* the dfp container div was not being resized, which results in content overlap * little cleanup
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* the dfp container div was not being resized, which results in content overlap * little cleanup
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* the dfp container div was not being resized, which results in content overlap * little cleanup
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* the dfp container div was not being resized, which results in content overlap * little cleanup
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* the dfp container div was not being resized, which results in content overlap * little cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This fixes the problem where safeFrame creatives are not resized correctly when DFP size override is enabled (initial size is 1x1)