Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Prebid label to console logs #2966

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

andyblackwell
Copy link
Contributor

@andyblackwell andyblackwell commented Aug 12, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Prefix prebid console logs with a label. Easier to single out prebid logs at a glance, and makes it simple to filter down to just prebid logs.
notes:
- I removed the current param count limitations for a few of the methods (logMessage, logInfo, logWarn), so they can behave like the native methods
- because of this, I removed current formatting that injects the text : params : between the current params 1(msg) and 2(args ) output
- label color is Prebid blue #3b88c3, taken from prebid.org

Other information

prebid_console_log_label

…e calls to all work with N args like the native methods
@andyblackwell
Copy link
Contributor Author

Looks like a false positive circleci failure:

1) should have unique slot name parameter
     Yieldbot Adapter Unit Tests buildRequests
     request is undefined
@webpack:///test/spec/modules/yieldbotBidAdapter_spec.js:945:6 <- test/test_index.js:138495:11

Doesn't seem like I have the ability to re-run the test, so will wait for some help there.
(Using this PR as my intro to contributing)

@jsnellbaker jsnellbaker self-requested a review August 13, 2018 13:03
@jsnellbaker jsnellbaker self-assigned this Aug 13, 2018
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker added needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Aug 14, 2018
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice and clean. Thanks!

@mkendall07 mkendall07 merged commit e643997 into prebid:master Aug 14, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
…e calls to all work with N args like the native methods (prebid#2966)
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
…e calls to all work with N args like the native methods (prebid#2966)
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
…e calls to all work with N args like the native methods (prebid#2966)
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
…e calls to all work with N args like the native methods (prebid#2966)
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
…e calls to all work with N args like the native methods (prebid#2966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants