-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Prebid label to console logs #2966
Conversation
…e calls to all work with N args like the native methods
Looks like a false positive circleci failure:
Doesn't seem like I have the ability to re-run the test, so will wait for some help there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice and clean. Thanks!
…e calls to all work with N args like the native methods (prebid#2966)
…e calls to all work with N args like the native methods (prebid#2966)
…e calls to all work with N args like the native methods (prebid#2966)
…e calls to all work with N args like the native methods (prebid#2966)
…e calls to all work with N args like the native methods (prebid#2966)
Type of change
Description of change
Prefix prebid console logs with a label. Easier to single out prebid logs at a glance, and makes it simple to filter down to just prebid logs.
notes:
- I removed the current param count limitations for a few of the methods (logMessage, logInfo, logWarn), so they can behave like the native methods
- because of this, I removed current formatting that injects the text
: params :
between the current params 1(msg
) and 2(args
) output- label color is Prebid blue
#3b88c3
, taken from prebid.orgOther information