Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New adapter Coinzilla #3385

Merged
merged 3 commits into from
Jan 2, 2019
Merged

New adapter Coinzilla #3385

merged 3 commits into from
Jan 2, 2019

Conversation

arkan303
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
var adUnits = [{
    code: 'test-ad-div',
    sizes: [[300, 250]],
    bids: [{
    bidder: 'coinzilla',
      params: { 
        placementId: 'testPlacementId'
      }
    }]
  }];

Other information

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arkan303

Thanks for submitting this adapter.

Overall it looks fine, though there are a few things that need to be reviewed.

In addition to the in-line comments below, when I tried to test the adapter with the params in the md file - I was encountering a CORS error on the url https://request.czilladx.com/serve/request.php. Could you take a look into this?

modules/coinzillaBidAdapter.js Outdated Show resolved Hide resolved
modules/coinzillaBidAdapter.js Outdated Show resolved Hide resolved
@arkan303
Copy link
Contributor Author

Hi @jsnellbaker
Thank you for your feedback! Everything is now fixed as you told us. We are looking forward to get a new review from you.
Keep in touch!

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates; LGTM

@jsnellbaker jsnellbaker merged commit e3c67d0 into prebid:master Jan 2, 2019
olafbuitelaar pushed a commit to olafbuitelaar/Prebid.js that referenced this pull request Jan 3, 2019
* New adapter "Coinzilla" added

* Solved required modifications related to bidderRequest.referrerInfo.referer
amuraco pushed a commit to amuraco/Prebid.js that referenced this pull request Jan 28, 2019
* New adapter "Coinzilla" added

* Solved required modifications related to bidderRequest.referrerInfo.referer
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* New adapter "Coinzilla" added

* Solved required modifications related to bidderRequest.referrerInfo.referer
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* New adapter "Coinzilla" added

* Solved required modifications related to bidderRequest.referrerInfo.referer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants