Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of Prebid #349

Merged
merged 58 commits into from
May 18, 2016
Merged

Refactor of Prebid #349

merged 58 commits into from
May 18, 2016

Commits on May 11, 2016

  1. Concurrent bid requests 

    * remove small helper functions for readability
* remove bidmanager.setBidderMap (not used)
* remove createEmptyBidResponseObj (just return object literal)
* remove pb_preBidders as unused
* refactor pbjs.requestBids and adaptermanager.callBids
* refactor bid count, rearrange getPriceBucketStrings
* refactor of targeting to set and clear before and after ad server call
    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    97fbbf8 View commit details
    Browse the repository at this point in the history

  2. ad being rendered, still in progress

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    ead59fc View commit details
    Browse the repository at this point in the history

  3. fix bug in appnexus adapter, lower timeout duration

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    ae38f32 View commit details
    Browse the repository at this point in the history

  4. notes

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    a015460 View commit details
    Browse the repository at this point in the history

  5. render ads as soon as all bids are back

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    fcb2aa6 View commit details
    Browse the repository at this point in the history

  6. remove deprecated code

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    96fca00 View commit details
    Browse the repository at this point in the history

  7. add small composable functions for readability, comment out a few API… 

    … methods
    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    280dbc5 View commit details
    Browse the repository at this point in the history

  8. comment API methods and related tests

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    965a07e View commit details
    Browse the repository at this point in the history

  9. adds fixtures, refactor tests, comment some api tests until methods a… 

    …re restored
    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    d6e0817 View commit details
    Browse the repository at this point in the history

  10. restore API methods, add fixtures functions, fix tests

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    9b134b4 View commit details
    Browse the repository at this point in the history

  11. restore all adpaters, remove deprecated code and tests

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    e782a5b View commit details
    Browse the repository at this point in the history

  12. review notes

    protonate committed May 11, 2016
    Configuration menu
    Copy the full SHA
    e1a3a70 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2016

  1. review notes: naming things, restore api methods, move composables to… 

    … utils
    protonate committed May 12, 2016
    Configuration menu
    Copy the full SHA
    d36eccd View commit details
    Browse the repository at this point in the history

  2. exclude adapters from coverage reporting

    protonate committed May 12, 2016
    Configuration menu
    Copy the full SHA
    1db6f0b View commit details
    Browse the repository at this point in the history

  3. include adapters in coverage reporting

    protonate committed May 12, 2016
    Configuration menu
    Copy the full SHA
    bf1e3b3 View commit details
    Browse the repository at this point in the history

  4. restore bidsAvailableForAdapter API method, move getBidRequest to… 

    … utils
    protonate committed May 12, 2016
    Configuration menu
    Copy the full SHA
    921667c View commit details
    Browse the repository at this point in the history

  5. restore test for getAdserverTargetingForAdUnitCodeStr

    protonate committed May 12, 2016
    Configuration menu
    Copy the full SHA
    0d669e7 View commit details
    Browse the repository at this point in the history

  6. Fix pbjs.enableSendAllBids() when using DivId for your adunit.code.

    @mkendall07
    mkendall07 committed May 12, 2016
    Configuration menu
    Copy the full SHA
    bb05754 View commit details
    Browse the repository at this point in the history

  7. fix object destructuring bug in pbjs.requestBids method signature

    protonate committed May 12, 2016
    Configuration menu
    Copy the full SHA
    e914f77 View commit details
    Browse the repository at this point in the history

  8. bug fixes: allBidsAvailable should return boolean, wrap one time exte… 

    …rnal callback in array, object destructuring in requestBids method signature restored
    protonate committed May 12, 2016
    Configuration menu
    Copy the full SHA
    0ef87fe View commit details
    Browse the repository at this point in the history

Commits on May 13, 2016

  1. move getKeys and getVal to utils module, rename bidSet to `bidd… 

    …erRequest`
    protonate committed May 13, 2016
    Configuration menu
    Copy the full SHA
    be317dc View commit details
    Browse the repository at this point in the history

  2. Derive bidder codes from adUnits, fixes "Calling All Bidders" bug, al… 

    …so move `getBidderCodes` to utils
    protonate committed May 13, 2016
    Configuration menu
    Copy the full SHA
    638c0a2 View commit details
    Browse the repository at this point in the history

  3. fix getAdServerTargeting test

    protonate committed May 13, 2016
    Configuration menu
    Copy the full SHA
    e2ee6f0 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2016

  1. Fix token illegal error

    @mkendall07
    mkendall07 committed May 16, 2016
    Configuration menu
    Copy the full SHA
    57d53e7 View commit details
    Browse the repository at this point in the history

  2. Concurrent bid requests 

    * remove small helper functions for readability
* remove bidmanager.setBidderMap (not used)
* remove createEmptyBidResponseObj (just return object literal)
* remove pb_preBidders as unused
* refactor pbjs.requestBids and adaptermanager.callBids
* refactor bid count, rearrange getPriceBucketStrings
* refactor of targeting to set and clear before and after ad server call
    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    6e9d25b View commit details
    Browse the repository at this point in the history

  3. ad being rendered, still in progress

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    cfa3eea View commit details
    Browse the repository at this point in the history

  4. fix bug in appnexus adapter, lower timeout duration

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    ab944bd View commit details
    Browse the repository at this point in the history

  5. notes

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    052c15c View commit details
    Browse the repository at this point in the history

  6. render ads as soon as all bids are back

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    856f5f0 View commit details
    Browse the repository at this point in the history

  7. remove deprecated code

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    7df0a3b View commit details
    Browse the repository at this point in the history

  8. add small composable functions for readability, comment out a few API… 

    … methods
    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    562dd09 View commit details
    Browse the repository at this point in the history

  9. comment API methods and related tests

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    2051d55 View commit details
    Browse the repository at this point in the history

  10. adds fixtures, refactor tests, comment some api tests until methods a… 

    …re restored
    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    6f0d1fd View commit details
    Browse the repository at this point in the history

  11. restore API methods, add fixtures functions, fix tests

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    c605b82 View commit details
    Browse the repository at this point in the history

  12. restore all adpaters, remove deprecated code and tests

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    a5ee300 View commit details
    Browse the repository at this point in the history

  13. review notes

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    a679ce3 View commit details
    Browse the repository at this point in the history

  14. review notes: naming things, restore api methods, move composables to… 

    … utils
    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    c869737 View commit details
    Browse the repository at this point in the history

  15. exclude adapters from coverage reporting

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    9850e24 View commit details
    Browse the repository at this point in the history

  16. include adapters in coverage reporting

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    21f55e2 View commit details
    Browse the repository at this point in the history

  17. restore bidsAvailableForAdapter API method, move getBidRequest to… 

    … utils
    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    8c2a833 View commit details
    Browse the repository at this point in the history

  18. restore test for getAdserverTargetingForAdUnitCodeStr

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    bc13bbc View commit details
    Browse the repository at this point in the history

  19. fix object destructuring bug in pbjs.requestBids method signature

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    2af9d59 View commit details
    Browse the repository at this point in the history

  20. bug fixes: allBidsAvailable should return boolean, wrap one time exte… 

    …rnal callback in array, object destructuring in requestBids method signature restored
    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    bbc7ef6 View commit details
    Browse the repository at this point in the history

  21. move getKeys and getVal to utils module, rename bidSet to `bidd… 

    …erRequest`
    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    dfe2854 View commit details
    Browse the repository at this point in the history

  22. Derive bidder codes from adUnits, fixes "Calling All Bidders" bug, al… 

    …so move `getBidderCodes` to utils
    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    5e41aac View commit details
    Browse the repository at this point in the history

  23. fix getAdServerTargeting test

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    cc6e395 View commit details
    Browse the repository at this point in the history

  24. Fix token illegal error

    @mkendall07
    mkendall07 authored and protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    320c7c8 View commit details
    Browse the repository at this point in the history

  25. restore return value format for pbjs.getBidResponses

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    0924b39 View commit details
    Browse the repository at this point in the history

  26. fix merge conflicts

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    60a28a7 View commit details
    Browse the repository at this point in the history

  27. restore return format for getAdServerTargeting()

    protonate committed May 16, 2016
    Configuration menu
    Copy the full SHA
    b4e4f97 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2016

  1. restore getAdServerTargeting return value as map 

    merge `getBidResponses` to map
some more helper functions
fixtures and tests
    protonate committed May 17, 2016
    Configuration menu
    Copy the full SHA
    f99c833 View commit details
    Browse the repository at this point in the history

  2. Restore getBidResponsesForAdUnitCode()

    @mkendall07
    mkendall07 committed May 17, 2016
    Configuration menu
    Copy the full SHA
    0d9c738 View commit details
    Browse the repository at this point in the history

  3. restore getAdServerTargetingForAdUnitCodeStr return value as string… 

    … of querystring params

more fixtures and tests
    protonate committed May 17, 2016
    Configuration menu
    Copy the full SHA
    ad33048 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fp_refactor' of https://github.com/prebid/Prebid.js int… 

    …o fp_refactor

* 'fp_refactor' of https://github.com/prebid/Prebid.js:
  Restore getBidResponsesForAdUnitCode()
    protonate committed May 17, 2016
    Configuration menu
    Copy the full SHA
    b629a04 View commit details
    Browse the repository at this point in the history

  5. check if send all bids before adding bid landscape targeting

    protonate committed May 17, 2016
    Configuration menu
    Copy the full SHA
    770948f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2016

  1. Implement 'dense' price bucket mode 

    - Don't export getPriceBucketString
- Test 'dense' price bucket mode integration
    @matthewlane
    matthewlane committed May 18, 2016
    Configuration menu
    Copy the full SHA
    5ad34e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fp_refactor' into dense-mode 

    # Conflicts:
#	test/fixtures/fixtures.js
    @mkendall07
    mkendall07 committed May 18, 2016
    Configuration menu
    Copy the full SHA
    ce82e57 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dense-mode' into fp_refactor

    @mkendall07
    mkendall07 committed May 18, 2016
    Configuration menu
    Copy the full SHA
    340befa View commit details
    Browse the repository at this point in the history