Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial setup of hook subscribe refactor #3564

Closed
wants to merge 2 commits into from
Closed

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Sample mock-up of a new API for the hooks logic using a subscribe methodology. This is to address hook availability issues in the build file; specifically where attempting to attach a hook function in one file (such as bidderFactory) onto a hook point that hasn't be setup yet due to the load order of files in the build.

This new logic will attempt to hold a function that was trying to register and will back-fill the attachment when the hook point is created.

A example of the logic working can be found in the new test hook setup in the bidderFactory.

@jsnellbaker jsnellbaker deleted the hook_subscribe branch March 18, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant