-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit Advangelists Prebid Adapter #3588
Conversation
Submission of new Advangelists Prebid Adpater |
Fixed a test case related to domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove any commented out code, and remove all console.log usages.
Also, you need to add a documentation and link to it from this PR. Follow the instructions under 'Submitting your adapter' in the dev docs here: dev-docs/bidder-adaptor |
Here is the link for documentation, |
Hi, Let me know if any status change is needed here for you to review again. |
Docs PR prebid/prebid.github.io#1177 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, Can you please let me know when Advangelist's bidder adapter will get listed in Download page. |
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information