Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Advangelists Prebid Adapter #3588

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Conversation

trchandraprakash
Copy link
Contributor

@trchandraprakash trchandraprakash commented Feb 26, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@trchandraprakash
Copy link
Contributor Author

Submission of new Advangelists Prebid Adpater

@trchandraprakash
Copy link
Contributor Author

Fixed a test case related to domain.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove any commented out code, and remove all console.log usages.

modules/advangelistsBidAdapter.js Outdated Show resolved Hide resolved
modules/advangelistsBidAdapter.js Outdated Show resolved Hide resolved
modules/advangelistsBidAdapter.js Outdated Show resolved Hide resolved
modules/advangelistsBidAdapter.js Outdated Show resolved Hide resolved
modules/advangelistsBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/advangelistsBidAdapter_spec.js Outdated Show resolved Hide resolved
modules/advangelistsBidAdapter.js Outdated Show resolved Hide resolved
modules/advangelistsBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/advangelistsBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/advangelistsBidAdapter_spec.js Outdated Show resolved Hide resolved
@idettman
Copy link
Contributor

Also, you need to add a documentation and link to it from this PR. Follow the instructions under 'Submitting your adapter' in the dev docs here: dev-docs/bidder-adaptor

@trchandraprakash
Copy link
Contributor Author

Also, you need to add a documentation and link to it from this PR. Follow the instructions under 'Submitting your adapter' in the dev docs here: dev-docs/bidder-adaptor

Here is the link for documentation,
prebid/prebid.github.io@727ebc9

@trchandraprakash
Copy link
Contributor Author

Hi, Let me know if any status change is needed here for you to review again.

@bretg
Copy link
Collaborator

bretg commented Mar 3, 2019

Docs PR prebid/prebid.github.io#1177

@bretg bretg removed the needs docs label Mar 3, 2019
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman added LGTM and removed needs update labels Mar 4, 2019
@idettman idettman merged commit 0db21ff into prebid:master Mar 4, 2019
@trchandraprakash
Copy link
Contributor Author

Hi, Can you please let me know when Advangelist's bidder adapter will get listed in Download page.
Here - http://prebid.org/download.html
I see it got release with this version - https://github.com/prebid/Prebid.js/releases/tag/2.5.0
Let me know if anything pending from my side. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants