ozone adapter - fixup for gdpr and device objects #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afsheenb
changed the title
bretg
requested changes
Mar 4, 2019
- removed 3 IF statements because the condition was already tested in the validation method. - added more tests to the spec file (check ozoneData, customData & lotameData are in the right place, and also NOT in the old location as well as some GDPR based unit tests)
|
@bretg we've submitted updated unit tests, please review and let us know if any further updates are needed. cheers, --afsheen |
bretg
requested changes
Mar 7, 2019
modules/ozoneBidAdapter.js
Outdated
| @@ -77,13 +78,18 @@ export const spec = { | |||
|
|
|||
| delete ozoneRequest.test; // don't allow test to be set in the config - ONLY use $_GET['pbjs_debug'] | |||
| if (bidderRequest.gdprConsent) { | |||
| utils.logInfo('ADDING GDPR'); | |||
There was a problem hiding this comment.
These debug log entries are likely to be confusing to others - please consider removing them or at least annotating with your bidder name so it's more clear what's adding GDPR.
modules/ozoneBidAdapter.js
Outdated
| } | ||
| } else { | ||
| utils.logInfo('WILL NOT ADD GDPR'); |
There was a problem hiding this comment.
same - please either remove or add your bidder name
|
@bretg done, we've explicitly added the bidder name to the debug logging statements for clarity. |
bretg
approved these changes
Mar 8, 2019
This was referenced Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updating ozone adapter to send device w/h and GDPR consent string in request.