YIELDONE adapter - add buildRequests payload params #3611
Conversation
modules/yieldoneBidAdapter.js
Outdated
| payload.tmax = window.PREBID_TIMEOUT; | ||
| } else if (window.pbjsTimeout) { | ||
| payload.tmax = window.pbjsTimeout; | ||
| } |
There was a problem hiding this comment.
Hello @kusapan
One suggestion is you can utilize the PBJS config in order to also get the bidderTimeout.
This value will always be set.
payload.tmax = config.getConfig('bidderTimeout');
example:
This value is set by the publisher by:
pbjs.setConfig({
bidderTimeout: 850
});If it is not explicitly set by the publisher, then it defaults to 3000.
This number is the milliseconds that Prebid gives it's bidders to come back in time for the auction.
So I think it is a good value to send as your tmax.
If there are other reasonings or use cases I am unaware of as to why it would not be included please let me know!
There was a problem hiding this comment.
Hello @robertrmartinez
Thank you for reviewing.
Our team talks about how to handle tmax.
In this PR, tmax was deleted.
please confirm this.
| it('adUnitCode should be sent as uc parameters on any requests', function () { | ||
| expect(request[0].data.uc).to.equal('adunit-code1'); | ||
| expect(request[1].data.uc).to.equal('adunit-code2'); | ||
| }); |
There was a problem hiding this comment.
Thanks for adding a unit test!
Type of change
Description of change
ucadUnitCodetmaxtimeout setting by publishersample page
contact email of the adapter’s maintainer y1dev@platform-one.co.jp