Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Limelight bidder adapter #3835

Merged
merged 3 commits into from
May 20, 2019
Merged

Project Limelight bidder adapter #3835

merged 3 commits into from
May 20, 2019

Conversation

apykhteyev
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

New bidder adapter

Test Parameters for banner

    var adUnits = [{
                code: 'placementCode',
                sizes: [[300, 250]],
                bids: [{
                        bidder: 'project-limelight',
                        params: {
                            adUnitId: 0,
                            adUnitType: 'banner'
                        }
                    }]
                }
            ];

Test Parameters for video

var videoAdUnit = [{
                code: 'video1',
                sizes: [[300, 250]],
                bids: [{
                        bidder: 'project-limelight',
                        params: {
                            adUnitId: 0,
                            adUnitType: 'video'
                        }
                }]
            }];

Other information

prebid/prebid.github.io#1315 - docs PR

@jsnellbaker jsnellbaker self-requested a review May 17, 2019 14:46
@jsnellbaker jsnellbaker self-assigned this May 17, 2019
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @apykhteyev,

Thanks for submitting this new adapter. Overall everything looks good. There is one requested change in the adapter code (see note below).

I was able to test the adapter for both banner/video with the params you provided and saw they were working as expected. If you can make the recommended change, we should be good to merge.

Thanks.

import { registerBidder } from 'src/adapters/bidderFactory';
import { BANNER, VIDEO } from 'src/mediaTypes';
import {ajax} from '../src/ajax';
import * as utils from 'src/utils';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In lieu of this PR #3435, any imported files within a modules file needs to use the relative style path.

Can you please update these imports accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks for review

@jsnellbaker
Copy link
Collaborator

@apykhteyev Thanks for the update; LGTM.

@jsnellbaker jsnellbaker merged commit 45b519a into prebid:master May 20, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* Add Project Limelight adapter

* Change to relative paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants