-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Limelight bidder adapter #3835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @apykhteyev,
Thanks for submitting this new adapter. Overall everything looks good. There is one requested change in the adapter code (see note below).
I was able to test the adapter for both banner/video with the params you provided and saw they were working as expected. If you can make the recommended change, we should be good to merge.
Thanks.
import { registerBidder } from 'src/adapters/bidderFactory'; | ||
import { BANNER, VIDEO } from 'src/mediaTypes'; | ||
import {ajax} from '../src/ajax'; | ||
import * as utils from 'src/utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In lieu of this PR #3435, any imported files within a modules file needs to use the relative style path.
Can you please update these imports accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks for review
@apykhteyev Thanks for the update; LGTM. |
* Add Project Limelight adapter * Change to relative paths
Type of change
Description of change
New bidder adapter
Test Parameters for banner
Test Parameters for video
Other information
prebid/prebid.github.io#1315 - docs PR