Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update emoteevBidAdapter.js #3928

Merged
merged 8 commits into from
Jul 1, 2019
Merged

Update emoteevBidAdapter.js #3928

merged 8 commits into from
Jul 1, 2019

Commits on Jun 21, 2019

  1. remove pubCommonId import from emoteevBidAdapter

    @snapwich @piotr-yuxuan
    snapwich authored and piotr-yuxuan committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    ad0459f View commit details
    Browse the repository at this point in the history

  2. Update emoteevBidAdapter.js 

    Retrieve various data from the adapter configuration, and ensure they
are properly formatted:
- GDPR vendor consent
- Metadata: intended to be used as an ID for external partners
- Context: describe the context of the current ad unit

Test coverage for emoteevBidAdapter.js:
- Statements 94.83%
- Branches 98.39%
- Functions 100%
- Lines 94.34%

fixup! Update emoteevBidAdapter.js
    @piotr-yuxuan
    piotr-yuxuan committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    b97a9b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Format indentation

    @piotr-yuxuan
    piotr-yuxuan committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    afa294b View commit details
    Browse the repository at this point in the history

  2. More detailed integration page example

    @piotr-yuxuan
    piotr-yuxuan committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    cbfc207 View commit details
    Browse the repository at this point in the history

  3. Rename attribute to externalId

    @piotr-yuxuan
    piotr-yuxuan committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    2bfc302 View commit details
    Browse the repository at this point in the history

  4. Simplify names of constants

    @piotr-yuxuan
    piotr-yuxuan committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    0016ef7 View commit details
    Browse the repository at this point in the history

  5. Minor tweak

    @piotr-yuxuan
    piotr-yuxuan committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    ce376b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Update context value

    @piotr-yuxuan
    piotr-yuxuan committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    147e272 View commit details
    Browse the repository at this point in the history