Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert addition of video support to IX adapter as it is still in testing #3956

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

ix-certification
Copy link
Contributor

Type of change

  • Bugfix
  • Feature

Description of change

Reverts the addition of Video support to the IX adapter from PR #3901
This adapter change is still in testing and should not have been added to master yet.

Other information

See #3901

@jas-singh
Copy link

@harpere
@idettman

Hey guys,

Can have this merged asap. We are seeing an issue with this update to our adapter and would like to revert this change for now.

@jsnellbaker jsnellbaker self-requested a review July 1, 2019 12:42
@jsnellbaker jsnellbaker self-assigned this Jul 1, 2019
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 9c73631 into prebid:master Jul 1, 2019
@ix-prebid-support
Copy link
Contributor

Is there any chance to release tag this as 2.21.1 to avoid any issues with publishers that automatically update to the latest 2.21.0 release tag? @jaiminpanchal27

@jsnellbaker
Copy link
Collaborator

@ix-prebid-support We actually just released the 2.22.0 version of Prebid.js a few minutes ago. So these changes should be included in that release.

@ix-prebid-support
Copy link
Contributor

Seeing it now much appreciated @jsnellbaker We have also found a workaround for 2.21.0 and will resubmit our PR for a future release thank-you and enjoy the holiday!

VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants